githubmunger: label PRs based on certain files touched #79
Conversation
|
kubernetes/kubernetes#11280: would have added label kind/api-change |
|
@bgrant0607 at least a potential for #73 |
|
(before we run this, we'd need to create the new kind/* labels over there) |
|
Cool! I sampled several of the PRs and they look right to me. Reassigning to @brendandburns to review the actual munger. |
|
New labels created. |
|
will rebase right now against munger changes. |
eparis
force-pushed
the
label-based-on-files-touched
branch
from
7e0e297 to
d767ce8
Compare
|
@brendandburns ready for review. (I'm am working on a follow on PR to move the file->label map out of the code and into a config file.) |
| ) | ||
|
|
||
| var ( | ||
| _ = fmt.Print |
There was a problem hiding this comment.
It makes it so I can add/remove fmt.Print lines to debug without the compiler whining the "fmt" is unused.
|
Basically LGTM. I'm ok w/ the config file as a separate PR, but the next time you change that map I'm going to require it :P |
Start with just proposals and changes to the API. This is quickly going to get out of date...
eparis
force-pushed
the
label-based-on-files-touched
branch
from
d767ce8 to
5c19c57
Compare
|
Fixed name. #87 moves it from a map in the go file to outside. Hopefully makes things easier to review. |
Start with just proposals and changes to the API.