Add mungegithub to kubernetes/test-infra #1553
Conversation
|
@foxish Can you please make sure I didn't forget anything? Also, we would need to create the test-infra.submit-queue.k8s.io host |
apelisse
force-pushed
the
create-bot-for-test-infra
branch
from
53e4ece
to
cc3af8f
Compare
| http: | ||
| paths: | ||
| - backend: | ||
| serviceName: contrib-sq-status |
There was a problem hiding this comment.
service-name should be test-infra-sq-status
|
It should work mostly. Do we need the submit-queue itself to run? #762 (comment) stated that we may not want the submit-queue on each repo. cc @fejta |
|
Yes I want the submit-queue. I want a consistent experience in every repo in the kubernetes org. |
| kind: Service | ||
| metadata: | ||
| labels: | ||
| app: submit-queue |
There was a problem hiding this comment.
Can we add the grapher now that it exists?
There was a problem hiding this comment.
Do you mean the queue-health grapher?
|
LGTM |
|
Makes sense. @apelisse, can we prune the other mungers from that list for test-infra? We can start with the submit-queue, lgtm-after-commit, and needs-rebase mungers perhaps. Blunderbuss and so on can be started up later. |
| submit-queue.chart-url: "" | ||
| submit-queue.history-url: "" | ||
|
|
||
| # options used by the GCS feature. |
There was a problem hiding this comment.
Shouldn't these be non-empty?
There was a problem hiding this comment.
These are useful only if we use the jenkins instances. They can be blank here since we run only the travis presubmit and no other tests.
apelisse
force-pushed
the
create-bot-for-test-infra
branch
from
cc3af8f
to
bf3f62e
Compare
|
@foxish Can you please add LGTM label if it's ok with you. I've removed the blunderbuss munger. |
|
@apelisse I think we need to remove the check-labels munger as well since the labels.yaml file isn't present in test-infra repo. |
apelisse
force-pushed
the
create-bot-for-test-infra
branch
from
bf3f62e
to
aff119b
Compare
|
/lgtm |
|
We definitely want the check-labels munger. |
|
It is very important the experience is the same in every repo... then I don't have the friction of trying to learn how each and every repo behaves. |
|
Yeah, but maybe we also want to do it incrementally On Fri, Aug 19, 2016 at 2:14 PM Erick Fejta [email protected]
|
|
Sure, doesn't have to be in this PR, but any reason not to create a labels.yaml in the test-infra now? |
|
Yes, I agree. I think the next step would be to create the label file and turn up that munger as well. |
|
I'm not sure we want to create lots of unused labels? On Fri, Aug 19, 2016 at 2:16 PM Erick Fejta [email protected]
|
|
Automatic merge from submit-queue |
…or-test-infra Automatic merge from submit-queue Add mungegithub to kubernetes/test-infra Make sure the mungegithub is running for test-infra repository.
Make sure the mungegithub is running for test-infra repository.
This change is