This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[nginx-ingress-controller] cleanup before update updating nginx controller to 0.7 #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2016
aledbf
force-pushed
the
ingress-0.7
branch
2 times, most recently
from
ccb1e2f
to
154746e
Compare
aledbf
force-pushed
the
ingress-0.7
branch
3 times, most recently
from
cf637fa
to
4371273
Compare
aledbf
changed the title
| ) | ||
|
|
||
| const ( | ||
| secureUpstream = "ingress.kubernetes.io/secure-upstream" |
There was a problem hiding this comment.
please add a comment with explanantion, or link to docs about how the encryption is performed to the upstream (which certs are used etc).
| ingLister StoreToIngressLister | ||
| svcLister cache.StoreToServiceLister | ||
| endpLister cache.StoreToEndpointsLister | ||
| mapLister StoreToMapLister |
There was a problem hiding this comment.
can you rename to storetoconfigmaplister? since this makes it sounds like you're listing to a go map
|
LGTM, guess we'll need followups for examples and readme anyway so you can fix the nits in that |
| @@ -260,239 +258,6 @@ In case of an error in a request the body of the response is obtained from the ` | |||
| Using this two headers is possible to use a custom backend service like [this one](https://github.com/aledbf/contrib/tree/nginx-debug-server/Ingress/images/nginx-error-server) that inspect each request and returns a custom error page with the format expected by the client. Please check the example [custom-errors](examples/custom-errors/README.md) | |||
|
|
|||
|
|
|||
| ### Annotations | |||
There was a problem hiding this comment.
Was this deletion of documentation by accident? The README is now missing vital information about the available configuration options.
There was a problem hiding this comment.
@databus23 this is being added here #1130
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #930
fixes #884