This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
🌱 Adding new/updated ClusterVersion and VirtualCluster test suites #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Hein <[email protected]>
k8s-ci-robot
added
approved
|
/assign @Fei-Guo |
|
/milestone v0.1.x |
k8s-ci-robot
added
the
kind/cleanup
|
/kind bug |
|
Awesome work! /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christopherhein, Fei-Guo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've updated to controller-runtime 0.8.3 and were seeing flakes like #79 it made sense to take a second and step back and write tests for at least the
nativeprovisioned that some folks have been using and actually get the Reconcilers for bothClusterVersionandVirtualCluster. in doing so this removes the flakes between test suites and cleans up more code.Related
Closes #79
Related #27
Related #59
Signed-off-by: Chris Hein [email protected]