Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

✨ Adding virtualcluster to prow #68

Merged

Conversation

christopherhein
Copy link
Contributor

This adds virtualcluster/ subdirectory to the prow presubmit, this will allow us to validate if changes in PRs break VC or CAPN.

closes #64

Signed-off-by: Chris Hein [email protected]

/milestone v0.1.x
/kind cleanup

@k8s-ci-robot k8s-ci-robot added this to the v0.1.x milestone May 22, 2021
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2021
@christopherhein christopherhein force-pushed the chore/prow-scripts-vc branch from 76d6212 to 83a1af0 Compare May 22, 2021 00:59
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2021
@christopherhein
Copy link
Contributor Author

/cc @Fei-Guo @weiling61 @charleszheng44

@k8s-ci-robot k8s-ci-robot requested review from Fei-Guo and weiling61 May 22, 2021 01:12
@Fei-Guo
Copy link

Fei-Guo commented May 22, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5f78101 into kubernetes-retired:main May 22, 2021
@christopherhein christopherhein deleted the chore/prow-scripts-vc branch May 22, 2021 01:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🌱 Setup Prow Jobs for virtualcluster
3 participants