-
Notifications
You must be signed in to change notification settings - Fork 67
🐛 fix pod kube-api-access sa not found #352
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yoonmac The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @yoonmac! |
Hi @yoonmac. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @christopherhein could you please take a look at this pr? Thanks |
@wondywang , please take a look. |
@yoonmac can you make sure you sign the CLA too? /ok-to-test |
a92297e
to
f35957a
Compare
f35957a
to
934fd10
Compare
@christopherhein I have signed the CLA, now the commit can link to my profile. |
@wondywang , please take a look. Thanks |
This does seem to be a bug. I implement it internally based on the Admission plugin. Something went wrong with the conversion process. Many thanks to @yoonmac for pointing out this mistakes. /lgtm |
@christopherhein could you please help trigger the cla bot? thanks |
/ok-to-test |
/easycla |
@Fei-Guo Could you please help approve and merge? I need a new release version based on main. Thanks |
What this PR does / why we need it:
Currently, #348 PodKubeAPIAccessMutatorPlugin not works and will get "error looking up serviceAccount ...." error, this PR will fix this issue
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #