-
Notifications
You must be signed in to change notification settings - Fork 67
Add scaffolding #24
Add scaffolding #24
Conversation
/assign |
Fixes #19 |
6fad638
to
f3ac4d9
Compare
f3ac4d9
to
b349c02
Compare
We're going to need to regenerate this unfortunately and maybe to make this a little easier we should start with this PR only adding in the one type first, maybe NCP as a blank resource then we can add the rest of the types in individual PRs. Specifically cause these we're generated with the wrong proper boilerplate so the license headers are messed up - https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/hack/boilerplate.go.txt and also the wrong domain and groups. https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/PROJECT#L2 should have been |
We also should have these kinds under the |
b349c02
to
6b12e37
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charleszheng44, christopherhein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds the scaffolding generated by
kubebuilder
v3.