✨ Add foundation tooling and files #13
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @christopherhein |
k8s-ci-robot
added
approved
|
Yes, it's in Cluster API itself and it's updated by updating the hash version of the capi hack/tools module in |
k8s-ci-robot
added
the
do-not-merge/hold
|
Oh, missed the .gitignore 😂 |
That makes sense 👍 |
Signed-off-by: Vince Prignano <[email protected]>
|
Should be good to go! |
| @@ -0,0 +1,3 @@ | |||
| version: "2" | |||
There was a problem hiding this comment.
We'll be fast following to change this to 3 once we get https://github.com/kubernetes-sigs/kubebuilder/milestone/21 finished. We might even start this with the 3-alpha.
|
|
||
| // InitFlags initializes the flags. | ||
| func InitFlags(fs *pflag.FlagSet) { | ||
| fs.StringVar(&metricsAddr, "metrics-addr", ":8080", |
There was a problem hiding this comment.
We're going to fast follow to change this to metrics-bind-address
| fs.StringVar(&metricsAddr, "metrics-addr", ":8080", | ||
| "The address the metric endpoint binds to.") | ||
|
|
||
| fs.BoolVar(&enableLeaderElection, "enable-leader-election", false, |
There was a problem hiding this comment.
We're going to fast follow to change this to leader-elect
| fs.BoolVar(&enableLeaderElection, "enable-leader-election", false, | ||
| "Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.") | ||
|
|
||
| fs.DurationVar(&leaderElectionLeaseDuration, "leader-election-lease-duration", 15*time.Second, |
There was a problem hiding this comment.
Fast follow change this to leader-elect-lease-duration
| fs.DurationVar(&leaderElectionLeaseDuration, "leader-election-lease-duration", 15*time.Second, | ||
| "Interval at which non-leader candidates will wait to force acquire leadership (duration string)") | ||
|
|
||
| fs.DurationVar(&leaderElectionRenewDeadline, "leader-election-renew-deadline", 10*time.Second, |
There was a problem hiding this comment.
fast follow change this to leader-elect-renew-deadline
| fs.DurationVar(&leaderElectionRenewDeadline, "leader-election-renew-deadline", 10*time.Second, | ||
| "Duration that the leading controller manager will retry refreshing leadership before giving up (duration string)") | ||
|
|
||
| fs.DurationVar(&leaderElectionRetryPeriod, "leader-election-retry-period", 2*time.Second, |
There was a problem hiding this comment.
Fast follow change this to leader-elect-retry-period
|
Awesome, thanks for putting all this base work in @vincepri ! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christopherhein, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel 🎉 |
k8s-ci-robot
removed
the
do-not-merge/hold
This patchset adds a bunch of basic tools and files needed to start
working on the controllers within the cluster api ecosystem. Enables us
to speed through the basic chores to generate files, run prow jobs
(these still need to be setup at the time of writing), add all the
release tooling and automatic image building.
Signed-off-by: Vince Prignano [email protected]