Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Adding in-tree glossary for definitions #12

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Adding in-tree glossary for definitions #12

merged 1 commit into from
Nov 11, 2020

Conversation

christopherhein
Copy link
Contributor

Signed-off-by: Chris Hein [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 11, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 11, 2020
@christopherhein
Copy link
Contributor Author

/cc @charleszheng44 @Fei-Guo

@christopherhein christopherhein mentioned this pull request Nov 11, 2020
Merged
Fei-Guo
Fei-Guo approved these changes Nov 11, 2020
View reviewed changes
Copy link

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, Fei-Guo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Fei-Guo,christopherhein]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9d6b2ca into kubernetes-retired:master Nov 11, 2020
@christopherhein christopherhein deleted the chore/capn-glossary branch June 9, 2021 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@vincepri vincepri Awaiting requested review from vincepri

@charleszheng44 charleszheng44 Awaiting requested review from charleszheng44

Assignees

@Fei-Guo Fei-Guo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christopherhein @k8s-ci-robot @Fei-Guo