Release #95
Release #95
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
|
all updated! ptal @ashish-amarnath |
|
cc @detiber without bazel goreleaser is really nice. |
chuckha
force-pushed
the
release
branch
4 times, most recently
from
eba883c to
02eaf68
Compare
* Keep version information very short * Build docker images with goreleaser * Adds github workflow Signed-off-by: Chuck Ha <[email protected]>
|
@ashish-amarnath any thoughts on this one? I think once it merges I'm probably going to have to fix a bunch of little things in the release pipeline |
|
/lgtm |
k8s-ci-robot
added
do-not-merge/hold
|
/hold cancel lmk if you have any qs @detiber. I think outside of bazel this is super good. Might even be worth it with bazel. |
k8s-ci-robot
removed
the
do-not-merge/hold
| ADD third_party third_party | ||
|
|
||
| RUN go install -v ./cmd/capd-manager | ||
| FROM golang:1.12.7 |
There was a problem hiding this comment.
Since this isn't building anything, any reason not to use distroless here?
| - goos: linux | ||
| goarch: amd64 | ||
| binaries: | ||
| - capd-manager |
There was a problem hiding this comment.
Does this just use the top level Dockerfile?
What this PR does / why we need it:
This PR simplifies the version since we don't need anything but the actual tag.
It implements go releaser and uses goreleaser's strategy for building container images.
This removes using GitHub packages since those don't work for our use case.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #67
Special notes for your reviewer:
I added a service account to my own gcloud project and added the token as a secret to this project which is how this will have the correct permissions to push