Build container image on all pushes and publish image on push to master #75
Conversation
At the very least the login should succeed
Signed-off-by: Chuck Ha <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| } | ||
|
|
||
| action "Docker Registry" { | ||
| uses = "actions/docker/login@86ff551d26008267bb89ac11198ba7f1d807b699" | ||
| secrets = ["DOCKER_USERNAME", "DOCKER_PASSWORD", "DOCKER_REGISTRY_URL"] |
There was a problem hiding this comment.
Are these injected automatically?
There was a problem hiding this comment.
oh no, they are not. I had to create the secrets as an admin. There is a better way to do it with gpg which we should probably look into and use a robot user for these values instead of my personal account
There was a problem hiding this comment.
There was a problem hiding this comment.
oh, that's disappointing, it would be nice if there was cleaner integration with github package repository.
There was a problem hiding this comment.
Can the GitHub Token secret be used for this purpose instead of adding additional secrets?
|
Should we also expect "Checks" to run on this PR? I see 0 Checks |
|
I assume tests and verification can happen at PR time (before merging). That said, I'm not opposed if we want to duplicate it in GitHub CI as well, but that might require a larger effort. |
|
Also, I am not sure I understand the switch to github workflow thingy. Is this replacing prow/ test-infra tests we've been using so far? I didn't get that memo. |
|
I think the idea was to only use GitHub Actions for doing pushes for the |
|
@ashish-amarnath this is only for container images. There is no good place to put a container image for projects in kubernetes-sigs. Github packages fills that need and along with the image promoter work we can get images into a kubernetes sanctioned gcr repo (eventually) |
|
/lgtm |
What this PR does / why we need it:
This PR starts addressing #67
Special notes for your reviewer:
This will build an image but will not push until it merges to master.
/assign @detiber
Sorry for all the spam >.< this one finally does what I want.