Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Update main.workflow with secrets #74

Closed

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Jul 8, 2019

At the very least the login should succeed

What this PR does / why we need it:
This PR adds an action to push an image on every push

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #67

Special notes for your reviewer:
/hold

This should only run after a merge...push must be the wrong action

/assign @detiber

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

Verified

This commit was signed with the committer’s verified signature.
chuckha Chuck Ha
At the very least the login should succeed
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from justinsb and vincepri July 8, 2019 18:20
@chuckha chuckha closed this Jul 8, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants