Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Update main.workflow with secrets #73

Closed
wants to merge 15 commits into from
Closed

Update main.workflow with secrets #73

wants to merge 15 commits into from

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Jul 8, 2019

At the very least the login should succeed

What this PR does / why we need it:
This PR should push a new docker image...

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #67

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

NONE

one more @detiber

At the very least the login should succeed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from detiber and vincepri July 8, 2019 16:57
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2019
chuckha added 3 commits July 8, 2019 13:00
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
@ashish-amarnath
Copy link
Contributor

still not finding the Dockerfile suggest adding pwd to the script in a test commit and adjust the path to Dockerfile

@ashish-amarnath
Copy link
Contributor

you won the race :D

chuckha added 2 commits July 8, 2019 13:32
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2019
chuckha added 9 commits July 8, 2019 13:37
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
@chuckha chuckha closed this Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants