Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

change variable names #35

Merged
merged 1 commit into from
Jun 28, 2019
Merged

change variable names #35

merged 1 commit into from
Jun 28, 2019

Conversation

amy
Copy link
Contributor

@amy amy commented Jun 27, 2019

address #31
Changes variable name new to newMachine and variable name old to oldMachine.

@k8s-ci-robot k8s-ci-robot requested review from chuckha and detiber June 27, 2019 22:06
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @amy. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2019
@amy
Copy link
Contributor Author

amy commented Jun 27, 2019

/test

@chuckha
Copy link
Contributor

chuckha commented Jun 27, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2019
chuckha
chuckha approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:yeet:

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amy, chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@ashish-amarnath
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0e80989 into kubernetes-retired:master Jun 28, 2019
@amy amy mentioned this pull request Jul 3, 2019
Closed
6 tasks
@chuckha chuckha mentioned this pull request Jul 10, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chuckha chuckha chuckha approved these changes

@detiber detiber Awaiting requested review from detiber

Assignees

@ashish-amarnath ashish-amarnath

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amy @k8s-ci-robot @chuckha @ashish-amarnath