small refactor for actuator folder

[amy]

I moved the Cluster actuator related code from actuators.go to cluster.go under /actuators. This copies the pattern used for actuators/machine.go

[amy]

/assign @chuckha

[chuckha]

yay organization 📁

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amy, chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chuckha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[detiber]

Not directly related to this change, but any reason to share the same package between cluster and machine actuators? @chuckha

[chuckha]

@detiber Mostly this is because I prefer fewer packages. If they were their own package, they would each only contain one file and one type, which is somewhat of a go antipattern.

Since the implementation is fairly small and we are limited to the Cluster actuator and the Machine actuator I see little benefit of keeping each in its own package.

What benefits do you see us gaining from having separate packages?

[detiber]

What benefits do you see us gaining from having separate packages?

Mainly naming, cluster.NewActuator() vs actuator.NewClusterActuator(). I also wouldn't expect there to be shared code between the Cluster and Machine actuators, so belonging to the same package just feels a bit weird to me.

That said, I have no strong objections to keeping them in the same package.

[chuckha]

A fair point! I don't really think about types in packages as having to share code though. It's more of an organizational thing for me 🤔. The naming could use improving for sure though. Anyway, this is totally out of scope to the PR, sorry @amy:)

[detiber]

/lgtm