Be careful with control-plane vs controlplane

Signed-off-by: Chuck Ha <[email protected]>

capkactuators/machine.go

@@ -34,6 +34,12 @@ import (
 	"sigs.k8s.io/kind/pkg/cluster/nodes"
 )
 
+const (
+	// kind uses 'control-plane' and cluster-api uses 'controlplane'. Both use 'worker'.
+
+	clusterAPIControlPlaneSetLabel = "controlplane"
+)
+
 type Machine struct {
 	Core       corev1.CoreV1Interface
 	ClusterAPI v1alpha1.ClusterV1alpha1Interface
@@ -69,7 +75,7 @@ func (m *Machine) Create(ctx context.Context, c *clusterv1.Cluster, machine *clu
 	fmt.Printf("Is there a cluster? %v\n", clusterExists)
 	setValue := getRole(machine)
 	fmt.Printf("This node has a role of %q\n", setValue)
-	if setValue == constants.ControlPlaneNodeRoleValue {
+	if setValue == clusterAPIControlPlaneSetLabel {
 		if len(controlPlanes) > 0 {
 			fmt.Println("Adding a control plane")
 			controlPlaneNode, err := actions.AddControlPlane(c.Name, machine.Spec.Versions.ControlPlane)

cmd/capkctl/main.go

@@ -36,7 +36,7 @@ func (mo *machineOptions) initFlags(fs *flag.FlagSet) {
 	mo.name = fs.String("name", "my-machine", "The name of the machine")
 	mo.namespace = fs.String("namespace", "my-namespace", "The namespece of the machine")
 	mo.clusterName = fs.String("cluster-name", "my-cluster", "The name of the cluster the machine belongs to")
-	mo.set = fs.String("set", "worker", "The role of the machine. Valid entries ['worker', 'control-plane']")
+	mo.set = fs.String("set", "worker", "The role of the machine. Valid entries ['worker', 'controlplane']")
 	mo.version = fs.String("version", "v1.14.2", "The Kubernetes version to run")
 }
 
@@ -53,7 +53,7 @@ func main() {
 	controlPlane := flag.NewFlagSet("control-plane", flag.ExitOnError)
 	controlPlaneOpts := new(machineOptions)
 	controlPlaneOpts.initFlags(controlPlane)
-	*controlPlaneOpts.set = "control-plane"
+	*controlPlaneOpts.set = "controlplane"
 
 	worker := flag.NewFlagSet("worker", flag.ExitOnError)
 	workerOpts := new(machineOptions)

examples/simple-cluster.yaml

@@ -16,7 +16,6 @@ metadata:
   name: my-control-plane
   labels:
     cluster.k8s.io/cluster-name: my-cluster
-  annotations:
     set: "control-plane"
 spec:
   providerSpec: {}
@@ -27,8 +26,8 @@ metadata:
   name: worker
   labels:
     cluster.k8s.io/cluster-name: my-cluster
-  annotations:
     set: "worker"
+  annotations:
     name: "my-cluster-worker"
 spec:
   providerSpec: {}