Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

📖 use k8s-staging-ci-images vs kubernetes-ci-images #300

Merged

Conversation

spiffxp
Copy link
Contributor

@spiffxp spiffxp commented Jul 29, 2021

What this PR does / why we need it:

Document that the default CI images are pulled from
gcr.io/k8s-staging-ci-images, not gcr.io/kubernetes-ci-images

This was changed via kubernetes/kubernetes#97087
which landed 2021-01-14

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
n/a

Related:

the default was changed in kubernetes/kubernetes as of 2021-01-14
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2021
@spiffxp spiffxp changed the title 📖 use k8s-staging-ci-images vs kubernetes-ci-images 📖 use k8s-staging-ci-images vs kubernetes-ci-images Jul 29, 2021
@spiffxp
Copy link
Contributor Author

spiffxp commented Jul 29, 2021

/cc @detiber @vincepri

@k8s-ci-robot k8s-ci-robot requested review from detiber and vincepri July 29, 2021 15:32
@neolit123
Copy link
Contributor

i think this repository is stale and the code now lives under a k-sigs/cluster-api folder.
@vincepri @fabriziopandini is time to archive this repository?

@vincepri
Copy link
Contributor

Yes it can be archived.

@neolit123
Copy link
Contributor

neolit123 commented Jul 29, 2021

@vincepri
i will log an issue in k-sigs/cluster api as there are number of action items here, including test-infra cleanup.
EDIT: kubernetes-sigs/cluster-api#5037

@spiffxp i think we can merge this to omit it from the org search (e.g. https://cs.k8s.io/).
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021
@neolit123
Copy link
Contributor

i cannot merge it because i'm not in owners.
/assign @vincepri

@vincepri
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, spiffxp, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 22ae5f0 into kubernetes-retired:master Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants