Fix: Handle float apiserver buckets #965
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have some lint failures |
skl
reviewed
Aug 30, 2024
Depending on the version of client_golang and metrics format (Prometheus vs OpenMetrics), bucket names may contain either integer or float formatting. Use a regexp match to select either format. Signed-off-by: SuperQ <[email protected]>
SuperQ
force-pushed
the
latency_regexp_alt
branch
from
80f69a1
to
608c01f
Compare
|
@SuperQ FYI CI is still failing |
skl
reviewed
Sep 3, 2024
Comment on lines
+11
to
+14
| kubeApiserverReadResourceLatency: '1(\.0)?', | ||
| kubeApiserverReadNamespaceLatency: '5(\.0)?', | ||
| kubeApiserverReadClusterLatency: '30(\.0)?', | ||
| kubeApiserverWriteLatency: '1(\.0)?', |
There was a problem hiding this comment.
Suggested change
| kubeApiserverReadResourceLatency: '1(\.0)?', | |
| kubeApiserverReadNamespaceLatency: '5(\.0)?', | |
| kubeApiserverReadClusterLatency: '30(\.0)?', | |
| kubeApiserverWriteLatency: '1(\.0)?', | |
| kubeApiserverReadResourceLatency: '1(.0)?', | |
| kubeApiserverReadNamespaceLatency: '5(.0)?', | |
| kubeApiserverReadClusterLatency: '30(.0)?', | |
| kubeApiserverWriteLatency: '1(.0)?', |
There was a problem hiding this comment.
That doesn't seem correct. We need to escape the . in order to have a literal . match instead of a regexp any character match.
There was a problem hiding this comment.
Of course, you're right @SuperQ. What you need instead then is to double-double-escape! i.e.
- kubeApiserverReadResourceLatency: '1(\.0)?',
- kubeApiserverReadNamespaceLatency: '5(\.0)?',
- kubeApiserverReadClusterLatency: '30(\.0)?',
- kubeApiserverWriteLatency: '1(\.0)?',
+ kubeApiserverReadResourceLatency: '1(\\\\.0)?',
+ kubeApiserverReadNamespaceLatency: '5(\\\\.0)?',
+ kubeApiserverReadClusterLatency: '30(\\\\.0)?',
+ kubeApiserverWriteLatency: '1(\\\\.0)?',which would produce queries like:
sum by (cluster) (cluster_verb_scope_le:apiserver_request_sli_duration_seconds_bucket:increase30d{verb=~"POST|PUT|PATCH|DELETE",le=~"1(\\.0)?"})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the version of client_golang and metrics format (Prometheus vs OpenMetrics), bucket names may contain either integer or float formatting.
Use a regexp match to select either format.