Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Fix catalog chart rbac to use new namespacedServiceBrokerDisabled flag #2263

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

PK85
Copy link
Contributor

@PK85 PK85 commented Aug 6, 2018

namespacedServiceBrokerDisabled is defaulted to false in charts/catalog/values.yaml. Service catalog has new ns-scoped resources but could not work with them cause of missing rbac settings.

@k8s-ci-robot k8s-ci-robot requested review from jboyd01 and pmorie August 6, 2018 12:51
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2018
@jboyd01
Copy link
Contributor

jboyd01 commented Aug 6, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 6, 2018
@PK85
Copy link
Contributor Author

PK85 commented Aug 6, 2018

done: CLA signature has beed fully registered

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 6, 2018
@jboyd01
Copy link
Contributor

jboyd01 commented Aug 6, 2018

/approve
/lgtm
Thanks @PK85

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jboyd01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2018
@jboyd01 jboyd01 added the LGTM1 label Aug 6, 2018
@jboyd01 jboyd01 requested review from jberkhahn and removed request for pmorie August 6, 2018 13:46
@k8s-ci-robot k8s-ci-robot merged commit 2d3f480 into kubernetes-retired:master Aug 6, 2018
@PK85 PK85 deleted the chart-rback-fix branch August 6, 2018 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. LGTM1 LGTM2 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants