Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link #236

Merged
merged 1 commit into from
May 6, 2019
Merged

Fix broken link #236

merged 1 commit into from
May 6, 2019

Conversation

arghya88
Copy link
Contributor

Fixes #235

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2019
@arghya88
Copy link
Contributor Author

/assign @DirectXMan12

@prankul88 prankul88 mentioned this pull request May 1, 2019
Closed
@ialidzhikov ialidzhikov mentioned this pull request May 1, 2019
Closed
This was referenced May 2, 2019
Closed
Closed
@joelsmith
Copy link

/assign @kawych
/assign @brancz
Is there any chance we could get this merged? Judging from the fact that 5 virtually identical PRs have been opened to fix this link (including 4 of the last 5 PRs in this repo), people are using the link.

@s-urbaniak
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@s-urbaniak: changing LGTM is restricted to assignees, and only kubernetes-incubator/metrics-server repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brancz
Copy link

brancz commented May 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit f10687f into kubernetes-sigs:master May 6, 2019
@brancz brancz mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@kawych kawych Awaiting requested review from kawych

Assignees

@DirectXMan12 DirectXMan12

@kawych kawych

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to user guide not working
7 participants
@arghya88 @joelsmith @s-urbaniak @k8s-ci-robot @brancz @DirectXMan12 @kawych