Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Updated API Version, Added selector field. #1230

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Updated API Version, Added selector field. #1230

merged 1 commit into from
Oct 1, 2019

Conversation

zimmertr
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2019
@zimmertr
Copy link
Contributor Author

/assign @childsb

@zimmertr
Copy link
Contributor Author

zimmertr commented Oct 1, 2019

I'm unsure why cla/linuxfoundation is failing. I have:

  1. Signed up for a Linux Foundation account.
  2. Linked the Linux Foundation account to my this Github account.
  3. Signed the CNCF Individual Contributor License Agreement.
  4. Ensured that my local git user.name and user.email are the same as what is on my Github profile. Furthermore, as seen here the Blue Question mark referenced in Step 2 of this guide do not appear for me. Inferring that it is, indeed, associated with my email and name.

As for continuous-integration/travis-ci/pr, it appears that I am not at fault for the pipeline failing but I could be incorrect. I have not used Travis CI before.

  1. curl: (7) Failed to connect to whereami.travis-ci.com port 443: Connection timed out
  2. The command "eval git fetch origin +refs/pull/1229/merge: " failed. Retrying, 2 of 3.
  3. The command "eval git fetch origin +refs/pull/1229/merge: " failed 3 times.
  4. The command "git fetch origin +refs/pull/1229/merge:" failed and exited with 128 during .

Please advise on what is necessary to get approved for this PR. Thank you!

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 1, 2019
@zimmertr
Copy link
Contributor Author

zimmertr commented Oct 1, 2019

I ran a git commit --amend --reset-author and it looks like it's accepting that I signed the contributor document now. However, the Travis CI configuration still seems malformed. I'd add a PR for that too but I'd have no idea what I'm doing 😄

@wongma7
Copy link
Contributor

wongma7 commented Oct 1, 2019

/lgtm
/approve
Thank you. Travis fails randomly sometimes, nothing to worry about.

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 76918c2 into kubernetes-retired:master Oct 1, 2019
@zimmertr zimmertr deleted the fix_nfs_client_api branch October 1, 2019 05:06
@zimmertr zimmertr restored the fix_nfs_client_api branch October 1, 2019 05:06
@zimmertr
Copy link
Contributor Author

zimmertr commented Oct 1, 2019

@wongma7 I didn't realize at first that the deployment manifest is replicated in text in the Readme. I have opened a new PR to address that change here: #1231

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants