-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix doc about csi socket path #59
Conversation
Welcome @Sh4d1! |
Hi @Sh4d1. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @msau42 |
/assign @pohly |
/ok-to-test |
@pohly fixed :) |
README.md
Outdated
* This is the socket referenced by the `--csi-address` and `--kubelet-registration-path` arguments. | ||
* Note that if the csi socket is in the `/var/lib/kubelet/plugins/` path, kubelet may log a lot of harmful errors regarding grpc `GetInfo` call not implemented (see kubernetes/kubernetes#70485) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is resolved in 1.17. We have removed CSI 0.3 support and therefore also removed watching "/var/lib/kubelet/plugins" for plugin registration sockets. So from 1.17+, the "/var/lib/kubelet/plugins" directory won't cause log spam.
Also, I don't think "harmful" is right. It's not actually causing anything to error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I meant harmless 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I'll change the phrasing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msau42 better now?
Signed-off-by: Patrik Cyvoct <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, Sh4d1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…cy-openshift-4.16-csi-node-driver-registrar OCPBUGS-25117: Updating csi-node-driver-registrar-container image to be consistent with ART
Signed-off-by: Patrik Cyvoct [email protected]
/kind documentation
cc @pohly
What this PR does / why we need it:
Fix doc about CSI socket path.
The Kubelet is still scaning
/var/lib/kubelet/plugins
recursively, and trying to callGetInfo
on the CSI socket, which is not implemented and thus pollute the Kubelet with harmless error logsSpecial notes for your reviewer:
Does this PR introduce a user-facing change?: