Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc about csi socket path #59

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Dec 4, 2019

Signed-off-by: Patrik Cyvoct [email protected]

/kind documentation
cc @pohly

What this PR does / why we need it:
Fix doc about CSI socket path.
The Kubelet is still scaning /var/lib/kubelet/plugins recursively, and trying to call GetInfo on the CSI socket, which is not implemented and thus pollute the Kubelet with harmless error logs

Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @Sh4d1!

It looks like this is your first PR to kubernetes-csi/node-driver-registrar 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/node-driver-registrar has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Sh4d1. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2019
@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Dec 4, 2019

/assign @msau42

@Madhu-1
Copy link
Contributor

Madhu-1 commented Dec 4, 2019

/assign @pohly

README.md Outdated Show resolved Hide resolved
@pohly
Copy link
Contributor

pohly commented Dec 4, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2019
@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Dec 4, 2019

@pohly fixed :)

README.md Outdated
* This is the socket referenced by the `--csi-address` and `--kubelet-registration-path` arguments.
* Note that if the csi socket is in the `/var/lib/kubelet/plugins/` path, kubelet may log a lot of harmful errors regarding grpc `GetInfo` call not implemented (see kubernetes/kubernetes#70485)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is resolved in 1.17. We have removed CSI 0.3 support and therefore also removed watching "/var/lib/kubelet/plugins" for plugin registration sockets. So from 1.17+, the "/var/lib/kubelet/plugins" directory won't cause log spam.

Also, I don't think "harmful" is right. It's not actually causing anything to error.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant harmless 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I'll change the phrasing :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msau42 better now?

Signed-off-by: Patrik Cyvoct <[email protected]>
@msau42
Copy link
Collaborator

msau42 commented Dec 4, 2019

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, Sh4d1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8f7e0d3 into kubernetes-csi:master Dec 4, 2019
dobsonj pushed a commit to dobsonj/node-driver-registrar that referenced this pull request Dec 13, 2023
…cy-openshift-4.16-csi-node-driver-registrar

OCPBUGS-25117: Updating csi-node-driver-registrar-container image to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants