Revert "Remove mkdir call while creating the registration probe file" #247
Conversation
k8s-ci-robot
added
release-note
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mauriciopoppe, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…247-upstream-release-2.6 Automated cherry pick of #247: Revert "Remove mkdir call while creating the registration
|
@mauriciopoppe @msau42 can we please get a release created post this merge? |
|
current v2.6.0 & v2.6.1 is broken, we should release v2.6.2 to have this fix. |
|
@mauriciopoppe considering many references we have to these broken releases, we need a new release. |
|
I created the CHANGELOG for v2.6.2 in #254, after that I'll create another tag |
Seems the docker image for v2.6.2 is still not published, could you please publish the same? |
|
Image promotion is done in another repo, kubernetes/k8s.io#4517 was just merged so it should be available now |
This version has a fix for an important bug at kubelet registration path. kubernetes-csi/node-driver-registrar#247 Signed-off-by: Humble Chirammal <[email protected]>
This version has a fix for an important bug at kubelet registration path. kubernetes-csi/node-driver-registrar#247 Signed-off-by: Humble Chirammal <[email protected]>
adb3af9d Merge pull request kubernetes-csi#252 from bells17/update-go-version b82ee388 Merge pull request kubernetes-csi#253 from bells17/fix-typo c3174562 Fix typo 0a785056 Bump to Go 1.22.3 edd89ad5 Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck 043fd099 Add test-logcheck target d7535ae0 Merge pull request kubernetes-csi#250 from jsafrane/go-1.22 b52e7ad3 Update go to 1.22.2 14fdb6f6 Merge pull request kubernetes-csi#247 from msau42/prow 9b4352e9 Update release playbook c7bb972c Fix release notes script to use fixed tags 463a0e9f Add script to update specific go modules git-subtree-dir: release-tools git-subtree-split: adb3af9dfa3ed4d1a922cd839bb48e0b73918617
What type of PR is this?
/kind bug
What this PR does / why we need it:
#214 created a bug described in #244, the assumption that I made that
/var/lib/kubelet/plugins/<drivername.example.com>/is created beforehand is valid but it's mapped to/csiin the container, the container later refers to/var/lib/kubelet/plugins/<drivername.example.com>/csi.sockwhich is a new path inside the container and therefore it doesn't exist.With that in mind, we should still create the path
/var/lib/kubelet/plugins/<drivername.example.com>/inside the container.Which issue(s) this PR fixes:
Related to #244, reopens #213
Does this PR introduce a user-facing change?:
/cc @jingxu97 @msau42