Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update livenessprobe initialDelaySeconds and timeoutSeconds #167

Merged
merged 1 commit into from
Nov 2, 2021
Merged

docs: update livenessprobe initialDelaySeconds and timeoutSeconds #167

merged 1 commit into from
Nov 2, 2021

Conversation

aramase
Copy link
Contributor

@aramase aramase commented Oct 5, 2021

Signed-off-by: Anish Ramasekar [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind documentation

What this PR does / why we need it:
Sets the initialDelaySeconds and timeoutSeconds for the node-driver-registrar livenessprobe check.

  • The default timeoutSeconds of 1s is honored starting from Kubernetes 1.20 and is aggressive. Setting the value to 15s which is appropriate for linux and windows.
  • Setting initialDelaySeconds to 30s to provide time for the socket to be created and driver to be registered during startup of the driver pods.

ref: kubernetes-sigs/secrets-store-csi-driver#729

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 5, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @aramase. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 5, 2021
@aramase
Copy link
Contributor Author

aramase commented Oct 5, 2021

/cc @marosset

@k8s-ci-robot
Copy link
Contributor

@aramase: GitHub didn't allow me to request PR reviews from the following users: marosset.

Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @marosset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aramase aramase force-pushed the update-liveness-probe-timeout branch from 34a19b3 to 4dc4a7b Compare October 5, 2021 22:27
@Jiawei0227
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2021
@Jiawei0227
Copy link
Contributor

/lgtm
cc @msau42 to decide if the number looks okay

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2021
@marosset
Copy link

marosset commented Oct 8, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

@marosset: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pohly pushed a commit to pohly/node-driver-registrar that referenced this pull request Oct 15, 2021
@c0va23
Squashed 'release-tools/' changes from c0a4fb1d..0438f15a
20f9345 
0438f15a Merge pull request kubernetes-csi#167 from c0va23/feature/release-armv7-image
4786f4d0 Merge pull request kubernetes-csi#168 from msau42/update-release-prereq
6a2dc64a Remove requirement to be top-level approver. Only maintainers membership is required to do a release
30a4f7bb Release armv7 image
ac8108f1 Merge pull request kubernetes-csi#165 from consideRatio/pr/update-github-links-ref-to-master-to-HEAD
999b483d docs: make github links reference HEAD instead of main
fd670693 docs: make github links reference HEAD instead of master

git-subtree-dir: release-tools
git-subtree-split: 0438f15a319d0c08bc1a82adf60c3e2ea02760ce
andyzhangx
andyzhangx approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@verult
Copy link
Contributor

verult commented Nov 2, 2021

/assign @msau42

@msau42
Copy link
Collaborator

msau42 commented Nov 2, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, aramase, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit c63de87 into kubernetes-csi:master Nov 2, 2021
@aramase aramase deleted the update-liveness-probe-timeout branch November 2, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@j-griffith j-griffith Awaiting requested review from j-griffith

@Jiawei0227 Jiawei0227 Awaiting requested review from Jiawei0227

Assignees

@andyzhangx andyzhangx

@Jiawei0227 Jiawei0227

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aramase @k8s-ci-robot @Jiawei0227 @marosset @verult @msau42 @andyzhangx