Add test-logcheck as a prerequisite for the test target

kubernetes-csi · May 15, 2024 · 5c16a09 · 5c16a09
1 parent abc918a
commit 5c16a09
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/Makefile b/Makefile
@@ -18,3 +18,5 @@ CMDS=csi-node-driver-registrar
 all: build
 
 include release-tools/build.make
+
+test: test-logcheck
diff --git a/go.mod b/go.mod
@@ -7,11 +7,12 @@ require (
 	golang.org/x/sys v0.16.0
 	google.golang.org/grpc v1.61.0
 	k8s.io/client-go v0.29.1
-  k8s.io/component-base v0.29.1
 	k8s.io/klog/v2 v2.120.1
 	k8s.io/kubelet v0.29.1
 )
 
+require k8s.io/component-base v0.29.1
+
 require (
 	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/blang/semver/v4 v4.0.0 // indirect

diff --git a/go.sum b/go.sum
@@ -168,8 +168,8 @@ golang.org/x/tools v0.0.0-20191108193012-7d206e10da11/go.mod h1:b+2E5dAYhXwXZwtn
 golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
 golang.org/x/tools v0.0.0-20200619180055-7c47624df98f/go.mod h1:EkVYQZoAsY45+roYkvgYkIh4xh/qjgUK9TdY2XT94GE=
 golang.org/x/tools v0.0.0-20210106214847-113979e3529a/go.mod h1:emZCQorbCU4vsT4fOWvOPXz4eW1wZW4PmDk9uLelYpA=
-golang.org/x/tools v0.12.0 h1:YW6HUoUmYBpwSgyaGaZq1fHjrBjX1rlpZ54T6mu2kss=
-golang.org/x/tools v0.12.0/go.mod h1:Sc0INKfu04TlqNoRA1hgpFZbhYXHPr4V5DzpSBTPqQM=
+golang.org/x/tools v0.16.1 h1:TLyB3WofjdOEepBHAU20JdNC1Zbg87elYofWYAY5oZA=
+golang.org/x/tools v0.16.1/go.mod h1:kYVVN6I1mBNoB1OX+noeBjbRk4IUEPa7JJ+TJMEooJ0=
 golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=

diff --git a/pkg/util/util_test.go b/pkg/util/util_test.go
@@ -90,7 +90,7 @@ func TestSocketPathSimple(t *testing.T) {
 
 	_, err = net.Listen("unix", socketPath)
 	if err != nil {
-		klog.Errorf("failed to listen on socket: %s with error: %+v", socketPath, err)
+		klog.ErrorS(err, "Failed to listen on socket", "socketPath", socketPath)
 		os.Exit(1)
 	}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -18,3 +18,5 @@ CMDS=csi-node-driver-registrar
		all: build

		include release-tools/build.make

		test: test-logcheck