Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #95: Call GetSnapshotStatus to check snapshot status #96

Closed
wants to merge 1 commit into from

Conversation

cwdsuzhou
Copy link

Fix #95.
In csi-snapshotter, function "GetSnapshotStatus" is never called and "CreateSnapshot" is called in function "GetSnapshotStatus".

In this PR, I have fixed #95 and changed the some unit tests.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cwdsuzhou
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lpabon

If they are not already assigned, you can assign the PR to them by writing /assign @lpabon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2019
@xing-yang
Copy link
Collaborator

We replaced the call to ListSnapshots with CreateSnapshot to check snapshot status when adding support to CSI spec 1.0:
#61

As stated in the CSI spec, ListSnapshots is optional. CreateSnapshot is the preferred way to check snapshot status.
https://github.com/container-storage-interface/spec/blob/master/spec.md#createsnapshot-deletesnapshot-listsnapshots

The CreateSnapshot call in a CSI driver should be idempotent. So repeated call to CreateSnapshot with same parameters should return the same result and just create one snapshot, not multiples.

@cwdsuzhou cwdsuzhou closed this Feb 19, 2019
dobsonj pushed a commit to dobsonj/external-snapshotter that referenced this pull request Oct 16, 2023
…cy-openshift-4.14-ose-csi-external-snapshotter

Updating ose-csi-external-snapshotter images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetSnapshotStatus is never called
3 participants