Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: Add certwatcher to webhook server #435

Conversation

ggriffiths
Copy link
Member

@ggriffiths ggriffiths commented Dec 2, 2020

Signed-off-by: Grant Griffiths [email protected]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Cherry-pick of #429

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:
n/a

Does this PR introduce a user-facing change?:

The validation-webhook server will now watch for changes to --tls-cert-file and --tls-private-key-file and update the server's TLS config accordingly.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 2, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 2, 2020
@xing-yang
Copy link
Collaborator

I think we probably need to backport some release-tools changes. See the following errors:

INFO: Version 1.19.1, installing CRDs and snapshot controller
error: unable to read URL "https://raw.githubusercontent.com/kubernetes-csi/external-snapshotter/v3.0.2/config/crd/snapshot.storage.k8s.io_volumesnapshotclasses.yaml", server reported 404 Not Found, status code=404
error: unable to read URL "https://raw.githubusercontent.com/kubernetes-csi/external-snapshotter/v3.0.2/config/crd/snapshot.storage.k8s.io_volumesnapshots.yaml", server reported 404 Not Found, status code=404
error: unable to read URL "https://raw.githubusercontent.com/kubernetes-csi/external-snapshotter/v3.0.2/config/crd/snapshot.storage.k8s.io_volumesnapshotcontents.yaml", server reported 404 Not Found, status code=404
error: the server doesn't have a resource type "volumesnapshotclasses"
22:57:31 waiting for snapshot CRDs, attempt #0
error: the server doesn't have a resource type "volumesnapshotclasses"
22:57:33 waiting for snapshot CRDs, attempt #1
error: the server doesn't have a resource type "volumesnapshotclasses"
22:57:35 waiting for snapshot CRDs, attempt #2

@xing-yang
Copy link
Collaborator

I think we need these two:

#430
#426

@ggriffiths
Copy link
Member Author

ggriffiths commented Dec 3, 2020

Opened separate PR with updated release tools @xing-yang
#436

Signed-off-by: Grant Griffiths <[email protected]>
@ggriffiths ggriffiths force-pushed the release-3.0_cherrypick_b457b08ffcd10bc90740e340fa9fdd9cef54a1ee branch from e7e6e38 to 09c4ed0 Compare December 5, 2020 02:45
@ggriffiths
Copy link
Member Author

/assign @xing-yang

@xing-yang xing-yang changed the title Add certwatcher to webhook server Cherry-pick: Add certwatcher to webhook server Dec 6, 2020
@xing-yang
Copy link
Collaborator

This should be a "/kind bug". Also need a release note.

@ggriffiths
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 6, 2020
@xing-yang
Copy link
Collaborator

release note?

@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggriffiths, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit b083035 into kubernetes-csi:release-3.0 Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants