Remove driver name from Snapshotter CreateSnapshot return values

[a-hilaly]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove the driver name from Snapshotter CreateSnapshot return values and use the cached one in SnapshotController

Which issue(s) this PR fixes:

Fixes #159

Special notes for your reviewer:

This PR make changes the controller.Handler and snapshotter.Snapshotter interfaces, more precisely in the CreateSnapshot Method

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: A-Hilaly
To complete the pull request process, please assign jingxu97
You can assign the PR to them by writing /assign @jingxu97 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @a-hilaly!

It looks like this is your first PR to kubernetes-csi/external-snapshotter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-snapshotter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @a-hilaly. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

/assign @jingxu97

[xing-yang]

Hi @a-hilaly, thank you for your contribution!

I'm in the middle of splitting the controller following the snapshot beta API PR's merge. It's going to completely change the structure of the currently controller. I took a look of your PR. It is probably easier for me just to incorporate your changes directly into my current PR: #182

[a-hilaly]

Ohh i'm sorry didn't pay attention to your PR. Sure i'm okkay with that ! You can do as suggested @xing-yang

[a-hilaly]

/close

[k8s-ci-robot]

@a-hilaly: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.