Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support ListSnapshots secrets #236

Closed
bells17 opened this issue Jan 14, 2020 · 6 comments · Fixed by #252
Closed

Add support ListSnapshots secrets #236

bells17 opened this issue Jan 14, 2020 · 6 comments · Fixed by #252

Comments

@bells17
Copy link
Contributor

bells17 commented Jan 14, 2020 •
edited
Loading

Hi, CSI supported ListSnapshots secrets in this PR.
So I want external-snapshotter to support ListSnapshots secrets.

ref: #152
@xing-yang
Copy link
Collaborator

There is a PR on this: #162. It was delayed because we were busy with the snapshot beta work. Hopefully we can get it in the next release.

@bells17 bells17 mentioned this issue Jan 14, 2020
Closed
@bells17
Copy link
Contributor Author

bells17 commented Jan 14, 2020

@xing-yang Oh, Thank you.
I created PR...but should I close this?
(I did not notice that there was PR...)

@xing-yang
Copy link
Collaborator

Oh, I didn't notice that you've already created a PR. I'm checking with the author of the other PR and see if he is still interested in working on it.

Leave your PR there now. Let me sort it out first. Thanks.

@bells17
Copy link
Contributor Author

bells17 commented Jan 14, 2020

I see. Thanks.

@xing-yang
Copy link
Collaborator

I have checked with the author of the other PR. You can keep your PR. I'll review it soon. Thanks for contributing!

@tdmanv
Copy link

tdmanv commented Jan 14, 2020

@bells17 @xing-yang thank you!

@bells17 bells17 mentioned this issue Feb 10, 2020
Merged
xing-yang added a commit to xing-yang/external-snapshotter that referenced this issue Oct 14, 2023
@xing-yang
Squashed 'release-tools/' changes from 984feec..f9d5b9c
4e2a4ab 
f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version
b01fd53 Bump csi-driver-host-path version up to v1.12.0

git-subtree-dir: release-tools
git-subtree-split: f9d5b9c
@xing-yang xing-yang mentioned this issue Oct 14, 2023
Closed
mowangdk added a commit to mowangdk/external-snapshotter that referenced this issue Oct 16, 2023
@mowangdk
Squashed 'release-tools/' changes from 984feec..f9d5b9c
e4951b8 
f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version
b01fd53 Bump csi-driver-host-path version up to v1.12.0

git-subtree-dir: release-tools
git-subtree-split: f9d5b9c
xing-yang added a commit to xing-yang/external-snapshotter that referenced this issue Oct 16, 2023
@xing-yang
Squashed 'release-tools/' changes from 984feec..f9d5b9c
061886c 
f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version
b01fd53 Bump csi-driver-host-path version up to v1.12.0

git-subtree-dir: release-tools
git-subtree-split: f9d5b9c
xing-yang added a commit to xing-yang/external-snapshotter that referenced this issue Oct 17, 2023
@xing-yang
Squashed 'release-tools/' changes from 984feec..f9d5b9c
36ca7a1 
f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version
b01fd53 Bump csi-driver-host-path version up to v1.12.0

git-subtree-dir: release-tools
git-subtree-split: f9d5b9c
@xing-yang xing-yang mentioned this issue Oct 17, 2023
Merged
andyzhangx pushed a commit to andyzhangx/external-snapshotter that referenced this issue Jun 5, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-…
f9d5b9c 
…driver-host-path_version

Bump csi-driver-host-path version up to v1.12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@xing-yang @tdmanv @bells17