Move APIs and generated clients outside pkg

[msau42]

It could also be exported as a go module.

[msau42]

/assign @yuxiangqian

[yuxiangqian]

/reopen

[yuxiangqian]

this would need another to resolve

[xing-yang]

I think the snapshot-controller should stay with the APIs and generated clients in the same repo. Otherwise there's no way to validate the APIs and we'll have more problems trying to sync up 3 repos.

[xing-yang]

/assign @xing-yang

[msau42]

Yes I think same repo but separate go modules would be great

[msau42]

Here's an example of csi-proxy creating a separate go module for their client library: https://github.com/kubernetes-csi/csi-proxy/tree/master/client

[xing-yang]

Thanks! Will take a look.

[Kartik494]

/assign

[Kartik494]

Yes I think same repo but separate go modules would be great

Hi @msau42 According to this we don't have to move apis and generated clients outside pkg?
Rather within pkg we have to create go module for apis and generated client like this client library Please let me know regarding this
Thanks

[msau42]

While technically you don't need to move it out of pkg, I think it makes more sense from a code organization perspective to move it out to a top level client

[Kartik494]

Thanks, i will follow up on this.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[xing-yang]

This is done.