Add event for snapshotting in progress

Signed-off-by: zhuc <[email protected]>
kubernetes-csi · Apr 30, 2020 · 1ee21c1 · 1ee21c1
1 parent d6be7e1
commit 1ee21c1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/common-controller/snapshot_controller.go b/pkg/common-controller/snapshot_controller.go
@@ -682,6 +682,9 @@ func (ctrl *csiSnapshotCommonController) createSnapshotContent(snapshot *crdv1.V
 		return nil, newControllerUpdateError(utils.SnapshotKey(snapshot), err.Error())
 	}
 
+	msg := fmt.Sprintf("Waiting for a snapshot %s to be created by the CSI driver.", utils.SnapshotKey(snapshot))
+	ctrl.eventRecorder.Event(snapshot, v1.EventTypeNormal, "CreatingSnapshot", msg)
+
 	// Update content in the cache store
 	_, err = ctrl.storeContentUpdate(updateContent)
 	if err != nil {

diff --git a/pkg/common-controller/snapshot_create_test.go b/pkg/common-controller/snapshot_create_test.go
@@ -206,7 +206,7 @@ func TestCreateSnapshotSync(t *testing.T) {
 				{"update", "volumesnapshots", errors.New("mock update error")},
 				{"update", "volumesnapshots", errors.New("mock update error")},
 			},
-			expectedEvents: []string{"Warning SnapshotStatusUpdateFailed"},
+			expectedEvents: []string{"Normal CreatingSnapshot"},
 			expectSuccess:  false,
 			test:           testSyncSnapshot,
 		},