Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Release tools repo subtree #89

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Sync Release tools repo subtree #89

merged 2 commits into from
Dec 17, 2024
+2 −2

Conversation

Rakshith-R
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Merge pull request pull request kubernetes-csi#268 from huww98/cloudbuild
Merge pull request pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

fixes current image creation job failures
refer: kubernetes-csi/csi-release-tools#268 (comment)

Does this PR introduce a user-facing change?:

NONE

@Rakshith-R
Squashed 'release-tools/' changes from 406a79a..0496593
15a9027 
0496593 Merge pull request #268 from huww98/cloudbuild
119aee1 Merge pull request #266 from jsafrane/bump-sanity-5.3.1
0ae5e52 Update cloudbuild image with go 1.21+
43bde06 Bump csi-sanity to 5.3.1

git-subtree-dir: release-tools
git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
@Rakshith-R
release-tools: update
4a9ecfd 
Merge pull request [pull request kubernetes-csi#268](kubernetes-csi/csi-release-tools#268) from huww98/cloudbuild
Merge pull request [pull request kubernetes-csi#266](kubernetes-csi/csi-release-tools#266) from jsafrane/bump-sanity-5.3.1

Signed-off-by: Rakshith R <[email protected]>
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Rakshith-R. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2024
@Rakshith-R
Copy link
Contributor Author

/cc @PrasadG193 @carlbraganza @hairyhum

PrasadG193
PrasadG193 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PrasadG193, Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 71aa3c5 into kubernetes-csi:main Dec 17, 2024
6 checks passed
@Rakshith-R Rakshith-R mentioned this pull request Dec 19, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@pohly pohly Awaiting requested review from pohly

@carlbraganza carlbraganza Awaiting requested review from carlbraganza

@hairyhum hairyhum Awaiting requested review from hairyhum

Assignees

@PrasadG193 PrasadG193

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rakshith-R @k8s-ci-robot @PrasadG193