Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear modify status when the operation is completed #421

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented Jul 26, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

clear modify status when the operation is completed

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/126350/pull-kubernetes-e2e-storage-kind-alpha-beta-features/1816409229657903104

{ failed [FAILED] While waiting for PVC to have expected VAC: Timed out after 600.000s.
expected claim's status to be modified with the given VolumeAttirbutesClass volume-modify-2403-e2e-vac-hostpathksd87, got instead:
    <*v1.PersistentVolumeClaim | 0xc00081a780>: 
        metadata:
          annotations:
            pv.kubernetes.io/bind-completed: "yes"
            pv.kubernetes.io/bound-by-controller: "yes"
            volume.beta.kubernetes.io/storage-provisioner: csi-hostpath-volume-modify-2403
            volume.kubernetes.io/storage-provisioner: csi-hostpath-volume-modify-2403
          creationTimestamp: "2024-07-25T10:07:28Z"
          finalizers:
          - kubernetes.io/pvc-protection
          generateName: csi-hostpath
          managedFields:
          - apiVersion: v1
            fieldsType: FieldsV1
            fieldsV1:
              f:metadata:
                f:annotations:
                  .: {}
                  f:pv.kubernetes.io/bind-completed: {}
                  f:pv.kubernetes.io/bound-by-controller: {}
                  f:volume.beta.kubernetes.io/storage-provisioner: {}
                  f:volume.kubernetes.io/storage-provisioner: {}
              f:spec:
                f:volumeName: {}
            manager: kube-controller-manager
            operation: Update
            time: "2024-07-25T10:07:39Z"
          - apiVersion: v1
            fieldsType: FieldsV1
            fieldsV1:
              f:status:
                f:accessModes: {}
                f:capacity:
                  .: {}
                  f:storage: {}
                f:phase: {}
            manager: kube-controller-manager
            operation: Update
            subresource: status
            time: "2024-07-25T10:07:39Z"
          - apiVersion: v1
            fieldsType: FieldsV1
            fieldsV1:
              f:metadata:
                f:generateName: {}
              f:spec:
                f:accessModes: {}
                f:resources:
                  f:requests:
                    .: {}
                    f:storage: {}
                f:storageClassName: {}
                f:volumeAttributesClassName: {}
                f:volumeMode: {}
            manager: e2e.test
            operation: Update
            time: "2024-07-25T10:07:46Z"
          - apiVersion: v1
            fieldsType: FieldsV1
            fieldsV1:
              f:status:
                f:currentVolumeAttributesClassName: {}
                f:modifyVolumeStatus:
                  .: {}
                  f:status: {}
                  f:targetVolumeAttributesClassName: {}
            manager: csi-resizer
            operation: Update
            subresource: status
            time: "2024-07-25T10:07:49Z"
          name: csi-hostpath5whwq
          namespace: volume-modify-2403
          resourceVersion: "1768"
          uid: 70279f62-3d1b-4a64-9924-f33e27609126
        spec:
          accessModes:
          - ReadWriteOnce
          resources:
            requests:
              storage: 1Gi
          storageClassName: volume-modify-2403zw8t8
          volumeAttributesClassName: volume-modify-2403-e2e-vac-hostpathksd87
          volumeMode: Block
          volumeName: pvc-70279f62-3d1b-4a64-9924-f33e27609126
        status:
          accessModes:
          - ReadWriteOnce
          capacity:
            storage: 1Gi
          currentVolumeAttributesClassName: volume-modify-2403-e2e-vac-hostpathksd87
          modifyVolumeStatus:
            status: ""
            targetVolumeAttributesClassName: volume-modify-2403-e2e-vac-hostpathksd87
          phase: Bound
In [It] at: k8s.io/kubernetes/test/e2e/storage/testsuites/volume_modify.go:196 @ 07/25/24 10:17:46.624

Which issue(s) this PR fixes:

Ref kubernetes/kubernetes#126350

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Clear modify status of a pvc when the modification operation is completed

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jul 26, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2024
@msau42
Copy link
Collaborator

msau42 commented Jul 26, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@msau42
Copy link
Collaborator

msau42 commented Jul 26, 2024

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot

@msau42: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 29a4667 into kubernetes-csi:master Jul 26, 2024
6 checks passed
@k8s-infra-cherrypick-robot

@msau42: new pull request created: #423

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants