Skip modifying volumes owned by other CSI drivers #419
Conversation
Signed-off-by: Connor Catlett <[email protected]>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XS
ConnorJC3
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| vacName := pvc.Spec.VolumeAttributesClassName | ||
| if vacName != nil && *vacName != "" && pvc.Status.Phase == v1.ClaimBound { | ||
| if vacName != nil && *vacName != "" && pvc.Status.Phase == v1.ClaimBound && pv.Spec.CSI.Driver == ctrl.name { |
There was a problem hiding this comment.
can we add a unit test for syncPVC if one doesn't exist?
|
/cherry-pick release-1.11 |
|
@msau42: new pull request created: #422 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes issue (3) from kubernetes/kubernetes#124151 (comment) - Today, the
external-resizerwill attempt to modify any PVC awaiting modification without checking for if it matches the local CSI driver.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
No test exercises
syncPVC, so I could not update the tests for this case. I have manually tested the change against multiple drivers.Does this PR introduce a user-facing change?: