Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changelog for 1.1 #134

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

gnufied
Copy link
Contributor

@gnufied gnufied commented Dec 17, 2020

Add changelog for 1.1

cc @msau42

/release-note-none

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2020
CHANGELOG-1.1.md Outdated
- Added leader election health check at the metrics port + path "/healthz/leader-election".
- klog/v2 is used for logging
- process_start_time metric is now reported
- `metrics-address` flag is deprecated and replaced by `http-endpoint`, which enables handlers from both metrics manager and leader election health check. ([#129](https://github.com/kubernetes-csi/external-resizer/pull/129), [@verult](https://github.com/verult))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this under deprecation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved

CHANGELOG-1.1.md Outdated

### Bug or Regression

- Changing distroless image back to multiarch ([#120](https://github.com/kubernetes-csi/external-resizer/pull/120), [@namrata-ibm](https://github.com/namrata-ibm))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this release note because it was only a temporary thing that never got released.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

CHANGELOG-1.1.md Outdated
- klog/v2 is used for logging
- process_start_time metric is now reported. ([#129](https://github.com/kubernetes-csi/external-resizer/pull/129), [@verult](https://github.com/verult))

### Deprecation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit can you move this to the top

@msau42
Copy link
Collaborator

msau42 commented Dec 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2020
@msau42
Copy link
Collaborator

msau42 commented Dec 17, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit d7317da into kubernetes-csi:master Dec 17, 2020
pohly added a commit to pohly/external-resizer that referenced this pull request Mar 18, 2021
1748b16 Merge pull request kubernetes-csi#136 from pohly/go-1.16
ec844ea remove travis.yml, Go 1.16
df76aba Merge pull request kubernetes-csi#134 from andyzhangx/add-build-arg
e314a56 add build-arg ARCH for building multi-arch images, e.g. ARG ARCH FROM k8s.gcr.io/build-image/debian-base-${ARCH}:v2.1.3

git-subtree-dir: release-tools
git-subtree-split: 1748b16b488381c34a86ddbee110e9ed523bcb20
jsafrane pushed a commit to jsafrane/external-resizer that referenced this pull request Jul 21, 2023
…ncy-openshift-4.12-ose-csi-external-resizer

Updating ose-csi-external-resizer images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants