Bumping csi-lib-utils to 0.9.0 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/XXL
msau42
reviewed
Dec 5, 2020
cmd/csi-resizer/main.go
Outdated
| // Start HTTP server for metrics + leader election healthz | ||
| go func() { | ||
| klog.Infof("ServeMux listening at %q", addr) | ||
| err := http.ListenAndServe(addr, mux) |
There was a problem hiding this comment.
do we need to check addr empty?
There was a problem hiding this comment.
thanks for the catch!
pkg/resizer/csi_resizer.go
Outdated
| metricsAddress, metricsPath string) (Resizer, error) { | ||
| driverName, err := getDriverName(csiClient, timeout) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("get driver name failed: %v", err) | ||
| } | ||
|
|
||
| klog.V(2).Infof("CSI driver name: %q", driverName) | ||
| metricsManager.SetDriverName(driverName) | ||
| metricsManager.StartMetricsEndpoint(metricsAddress, metricsPath) | ||
| if metricsAddress != "" { |
There was a problem hiding this comment.
is it possible to move this outside so that it's similar to how csi-attacher does it?
There was a problem hiding this comment.
I added the refactor as a separate commit. WDYT?
verult
force-pushed
the
le-healthcheck
branch
2 times, most recently
from
71e12cc to
a110795
Compare
verult
force-pushed
the
le-healthcheck
branch
from
a110795 to
7dfc7b0
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, verult The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
/test pull-kubernetes-csi-external-resizer-1-17-on-kubernetes-1-17 |
pohly
added a commit
to pohly/external-resizer
that referenced
this pull request
Feb 3, 2021
7bc70e5 Merge pull request kubernetes-csi#129 from pohly/squash-documentation e0b02e7 README.md: document usage of --squash 316cb95 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate 26e2ab1 fix: default boilerplate path 1add8c1 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag 3e811d6 prow.sh: fix "on-master" prow jobs git-subtree-dir: release-tools git-subtree-split: 7bc70e5264a5ce5f47780bdbc6c7b7f4e79243fa
gnufied
pushed a commit
to gnufied/external-resizer
that referenced
this pull request
Jun 15, 2022
…ncy-openshift-4.11-ose-csi-external-resizer Updating ose-csi-external-resizer images to be consistent with ART
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Does this PR introduce a user-facing change?:
/assign @msau42