Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix volume size mismatch between driver and PV #541

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

Jiawei0227
Copy link
Contributor

@Jiawei0227 Jiawei0227 commented Dec 17, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix the issue where csi provisioner does not honor the volume size returned from CreateVolumeResponse.

Which issue(s) this PR fixes:

Fixes # #199

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix an issue where the csi-provisioner does not honor the volume size returned from CreateVolumeResponse. Stop rounding up bytes returned from CreateVolume.

/cc @msau42
/cc @wongma7

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 17, 2020
@k8s-ci-robot k8s-ci-robot requested a review from msau42 December 17, 2020 01:55
@k8s-ci-robot
Copy link
Contributor

@Jiawei0227: GitHub didn't allow me to request PR reviews from the following users: wongma7.

Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix the issue where csi provisioner does not honor the volume size returned from CreateVolumeResponse.

Which issue(s) this PR fixes:

Fixes # #199

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix an issue where the csi-provisioner does not honor the volume size returned from CreateVolumeResponse.

/cc @msau42
/cc @wongma7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2020
@msau42
Copy link
Collaborator

msau42 commented Dec 17, 2020

/lgtm
/approve

For the release note, maybe make it more descriptive like "Stop rounding bytes returned from CreateVolume"

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jiawei0227, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@Jiawei0227
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants