Update README to 1.14 #249

jsafrane · 2019-03-13T15:11:06Z

Following external-attacher as example.
Removed #Build and #Test, they were not useful, added short doc/development.md.
Moved away from StatefulSet to Deployment. Deployment behaves better when a node gets disconnected from the rest of the cluster - new provisioner leader is elected in ~15 seconds, while it may take up to 5 minutes for StatefulSet to start a new replica. (Again, following external-attacher as sample)

Deployment behaves better when a node gets disconnected from the rest of the cluster - new provisioner leader is elected in ~15 seconds, while it may take up to 5 minutes for StatefulSet to start a new replica.

README.md

k8s-ci-robot · 2019-03-14T14:35:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deploy/kubernetes/deployment.yaml

README.md

pohly

Thanks for doing this. Just some minor spelling comments.

README.md

pohly · 2019-03-22T12:37:16Z

Where do we document that fsType can be set as parameter in a storage class for a CSI driver? The code is here:

external-provisioner/pkg/controller/controller.go

Lines 359 to 369 in 7f7d828

    
           fsTypesFound := 0 
        
           fsType := "" 
        
           for k, v := range options.Parameters { 
        
           	if strings.ToLower(k) == "fstype" || k == prefixedFsTypeKey { 
        
           		fsType = v 
        
           		fsTypesFound++ 
        
           	} 
        
           	if strings.ToLower(k) == "fstype" { 
        
           		klog.Warningf(deprecationWarning("fstype", prefixedFsTypeKey, "")) 
        
           	} 
        
           }

jsafrane · 2019-03-25T16:40:13Z

@pohly, StorageClass parameters should IMO go to https://kubernetes-csi.github.io/docs/external-provisioner.html#storageclass-parameters

jsafrane · 2019-03-25T16:40:48Z

... and fsType is already there.

README.md

It follows external-attacher example.

jsafrane · 2019-03-27T09:26:14Z

I squashed all the commits, hoping this is the final round of review :-)

msau42 · 2019-03-27T14:35:56Z

README.md

+* `--worker-threads <num>`: Number of simultaneously running `ControllerCreateVolume` and `ControllerDeleteVolume` operations. Default value is `100`.
+
+#### Other recognized arguments
+* `--feature-gates <gates>`: A set of comma separated `<feature-name>=<true|false>` pairs that describe feature gates for alpha/experimental features. See [list of features](#feature-status) or `--help` output for list of recognized features. Example: `--feature-gates Topology=false` to disable Topology feature that's enabled by default.


This has to be updated too

msau42 · 2019-03-27T16:36:09Z

/lgtm

Update 3.0 changelog

dc4d0ae20 Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b170e Use .go-version to get Kubernetes go version git-subtree-dir: release-tools git-subtree-split: dc4d0ae20a3dcce17fbfc745fb1f1e3b10cd9644

dc4d0ae20 Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b170e Use .go-version to get Kubernetes go version b54c1ba49 Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81e9 Change go version to 1.21.5 267b40e97 Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2de nominate self (carlory) as kubernetes-csi reviewer a17f536fc Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033de2 Use set -x instead of die 5deaf667c Add wrapper script for sidecar release f8c8cc4c7 Merge pull request kubernetes-csi#237 from msau42/prow b36b5bfdc Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc9a Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c4650889d pull-test.sh: avoid "git subtree pull" error 7b175a1e2 Update csi-test version to v5.2.0 987c90ccd Update go version to 1.21 to match k/k 2c625d41d Add script to generate patch release notes f9d5b9c05 Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd5372 Bump csi-driver-host-path version up to v1.12.0 984feece4 Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e60599 fixed broken links of testgrid dashboard git-subtree-dir: release-tools git-subtree-split: dc4d0ae20a3dcce17fbfc745fb1f1e3b10cd9644

dc4d0ae20 Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b170e Use .go-version to get Kubernetes go version git-subtree-dir: release-tools git-subtree-split: dc4d0ae20a3dcce17fbfc745fb1f1e3b10cd9644

Use Deployment with leader election instead of StatefulSet

52d1fbc

Deployment behaves better when a node gets disconnected from the rest of the cluster - new provisioner leader is elected in ~15 seconds, while it may take up to 5 minutes for StatefulSet to start a new replica.

k8s-ci-robot requested review from davidz627 and msau42 March 13, 2019 15:11

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2019

jsafrane force-pushed the readme-1.14 branch 2 times, most recently from 6b46823 to 1f49203 Compare March 13, 2019 15:15

msau42 reviewed Mar 13, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

jsafrane mentioned this pull request Mar 14, 2019

Scaling issue : When 100+ PVCs are created at the same time, the CSI external-provisioner experiences timeout toward the plugin #211

Closed

jsafrane force-pushed the readme-1.14 branch 3 times, most recently from ffe1b97 to 59977e4 Compare March 14, 2019 14:37

msau42 reviewed Mar 14, 2019

View reviewed changes

deploy/kubernetes/deployment.yaml Outdated Show resolved Hide resolved

jsafrane force-pushed the readme-1.14 branch from 59977e4 to d352285 Compare March 14, 2019 15:32

msau42 reviewed Mar 14, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

msau42 reviewed Mar 15, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

msau42 reviewed Mar 15, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

jsafrane force-pushed the readme-1.14 branch from ce2361d to c0d0150 Compare March 15, 2019 09:22

pohly requested changes Mar 15, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

msau42 reviewed Mar 15, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

jsafrane force-pushed the readme-1.14 branch from aab7883 to 713248e Compare March 15, 2019 16:51

msau42 reviewed Mar 20, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

msau42 reviewed Mar 21, 2019

View reviewed changes

README.md Show resolved Hide resolved

msau42 reviewed Mar 26, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

Update README to Kubernetes 1.14

386ce3b

It follows external-attacher example.

jsafrane force-pushed the readme-1.14 branch from eca12c1 to 9b60b0a Compare March 27, 2019 09:25

msau42 reviewed Mar 27, 2019

View reviewed changes

jsafrane force-pushed the readme-1.14 branch from 9b60b0a to 386ce3b Compare March 27, 2019 16:01

k8s-ci-robot assigned msau42 Mar 27, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2019

k8s-ci-robot merged commit a0ceb86 into kubernetes-csi:master Mar 27, 2019

msau42 mentioned this pull request Apr 5, 2019

Create proper README #228

Closed

jianglingxia mentioned this pull request Aug 23, 2019

Fix pluginpath for cephfs ceph/ceph-csi#460

Merged

kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this pull request Dec 29, 2023

Merge pull request kubernetes-csi#249 from msau42/changelog

626291a

Update 3.0 changelog

xing-yang mentioned this pull request Feb 22, 2024

Update release tools - go version #1163

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update README to 1.14 #249

Update README to 1.14 #249

jsafrane commented Mar 13, 2019

k8s-ci-robot commented Mar 14, 2019

pohly left a comment

pohly commented Mar 22, 2019

jsafrane commented Mar 25, 2019

jsafrane commented Mar 25, 2019

jsafrane commented Mar 27, 2019

msau42 Mar 27, 2019

jsafrane Mar 27, 2019

msau42 commented Mar 27, 2019

Update README to 1.14 #249

Update README to 1.14 #249

Conversation

jsafrane commented Mar 13, 2019

k8s-ci-robot commented Mar 14, 2019

pohly left a comment

Choose a reason for hiding this comment

pohly commented Mar 22, 2019

jsafrane commented Mar 25, 2019

jsafrane commented Mar 25, 2019

jsafrane commented Mar 27, 2019

msau42 Mar 27, 2019

Choose a reason for hiding this comment

jsafrane Mar 27, 2019

Choose a reason for hiding this comment

msau42 commented Mar 27, 2019