Add leader election. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External attacher can now run in Deployments. One attacher per driver is active, others are standby to simplify the implementation. It must be explicitly enabled - it needs namespace for a config map where the leader election is stored.
jsafrane
force-pushed
the
leader-election
branch
2 times, most recently
from
16777de to
58bdbaf
Compare
lpabon
requested changes
May 9, 2018
| }, | ||
| OnStoppedLeading: func() { | ||
| glog.Error("Stopped leading") | ||
| os.Exit(1) |
There was a problem hiding this comment.
This leader election code is new to me. Why quit and kill the program which will restart the container which may look like many errors to users. Is there another way to just go back into waiting?
There was a problem hiding this comment.
There is, but the fact that leader lost its leadership means that something really bad happened to the leader (or API server) - it was not able to update an API object for 30 seconds.
Kubernetes controller-manager dies too:
lpabon
approved these changes
May 14, 2018
jsafrane
pushed a commit
to jsafrane/external-attacher
that referenced
this pull request
Jul 21, 2023
…cy-openshift-4.13-csi-attacher Updating csi-attacher images to be consistent with ART
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External attacher can now run in Deployments. One attacher per driver is active, others are standby to simplify the implementation.
It must be explicitly enabled - it needs namespace for a config map where the leader election is stored.
Fixes: #46