-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency go modules for k8s v1.26.0 #395
Update dependency go modules for k8s v1.26.0 #395
Conversation
5a2022a
to
ee2b395
Compare
/assign @msau42 |
/release-label-node |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, sunnylovestiramisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-label-none |
/release-note-none |
/lgtm |
@sunnylovestiramisu looks like some dependencies are still with rc tag https://github.com/kubernetes-csi/external-attacher/pull/395/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L17 or see #396 . considering you have filed PRs in sidecar repos, it would be better to revisit the existing PRs too |
@humblec good catch, I missed that one. |
yw 👍 |
I was running the script go-get-kubernetes.sh and this is what the script generated. Do we usually manually update dependencies after running the script? It happened twice already for both 1.26.0-rc and 1.26.0. |
I think it's worth digging more into the script to figure out why it's not updating those. We want to get to a state where the script is reliable and doesn't require modifying by hand afterwards |
Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p 1.26.0