Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: go module requirements for semantic versioning #209

Merged
merged 3 commits into from
Jan 28, 2020
Merged

fix: go module requirements for semantic versioning #209

merged 3 commits into from
Jan 28, 2020

Conversation

alex1989hu
Copy link
Contributor

@alex1989hu alex1989hu commented Jan 25, 2020 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix go module requirements for semantic versioning

Which issue(s) this PR fixes:
Fixes #208.

Special notes for your reviewer:
Adding Go dep compatibility should be decided
Does this PR introduce a user-facing change?:

Update package path to v2. Vendoring with dep depends on https://github.com/golang/dep/pull/1963 or the workaround described in v2/README.md.

@alex1989hu
fix: update Go 1.13
2202065 
Previous commit (5e773d2) updates CI but go.mod should follow it

Signed-off-by: Alex Szakaly <[email protected]>
@alex1989hu
fix: go module requirements for semantic versioning
8e9aba0 
Fixes issue #208.

Signed-off-by: Alex Szakaly <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 25, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @alex1989hu!

It looks like this is your first PR to kubernetes-csi/external-attacher 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-attacher has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @alex1989hu. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2020
@alex1989hu
Copy link
Contributor Author

/assign @msau42

@jsafrane
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2020
@jsafrane
Copy link
Contributor

@alex1989hu, is there anything missing in this PR? It looks good to me...

@alex1989hu alex1989hu marked this pull request as ready for review January 27, 2020 16:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2020
@alex1989hu
Copy link
Contributor Author

@alex1989hu, is there anything missing in this PR? It looks good to me...

If you do not want to keep the dep compatibility, it is fine 👍

@msau42
Copy link
Collaborator

msau42 commented Jan 27, 2020

Do we intend to backport this? If so, then we should probably keep dep compatibility.

@jsafrane
Copy link
Contributor

The ultimate question is how hard is it to get dep support?

@alex1989hu
Copy link
Contributor Author

It is not hard, but has negative side effect: symlink handling on Windows

@msau42
Copy link
Collaborator

msau42 commented Jan 27, 2020

If we want to backport this, then we should keep backwards compatibility with dep. However, we can deprecate that and say for v3, we'll remove it.

@alex1989hu
feat: add compatibility with dep
7e9187c 
This commit adds the compatibility with dep (Go dependency
management tool) via symlink creation (same method applied
in kubernetes-csi/csi-test)

Signed-off-by: Alex Szakaly <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2020
@alex1989hu
Copy link
Contributor Author

If we want to backport this, then we should keep backwards compatibility with dep. However, we can deprecate that and say for v3, we'll remove it.

Added in separate commit

@jsafrane
Copy link
Contributor

/lgtm
/approve

Thanks for the PR!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alex1989hu, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 57193d7 into kubernetes-csi:master Jan 28, 2020
@alex1989hu alex1989hu deleted the fix/gomod-v2-package branch January 28, 2020 17:26
@alex1989hu alex1989hu mentioned this pull request Jan 28, 2020
Merged
@jsafrane jsafrane mentioned this pull request Jan 31, 2020
Closed
@pohly pohly mentioned this pull request Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@sbezverk sbezverk Awaiting requested review from sbezverk

Assignees

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect repository layour for v2 Go Modules
4 participants
@alex1989hu @k8s-ci-robot @jsafrane @msau42