-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrub secrets 0.4 #111
Scrub secrets 0.4 #111
Conversation
Signed-off-by: Jose A. Rivera <[email protected]>
Looks like go version used by travis is 1.10. You can update it to 1.11 here: https://github.com/kubernetes-csi/external-attacher/blob/master/.travis.yml |
/assign |
Signed-off-by: Jose A. Rivera <[email protected]>
6106615
to
10dbd73
Compare
@msau42 Looks like it didn't like some whitespace changes that my editor made. I removed them and the |
/lgtm |
/assign @saad-ali for approval |
@davidz627: GitHub didn't allow me to assign the following users: for, approval. Note that only kubernetes-csi members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jarrpa, msau42, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.