Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Use updated CSINodeInfo #100

Closed
wants to merge 1 commit into from
Closed

WIP: Use updated CSINodeInfo #100

wants to merge 1 commit into from

Conversation

xing-yang
Copy link
Contributor

This PR uses updated CSINodeInfo. It is a temporary fix until
vendor files are updated properly. Update to K8S v1.13.0-beta.1
is dependent on the dependencies in kubernetes-csi-migration-library.

Fixes: #99

@xing-yang
WIP: Use updated CSINodeInfo
72143d9 
This PR uses updated CSINodeInfo. It is a temporary fix until
vendor files are updated properly. Update to K8S v1.13.0-beta.1
is dependent on the dependencies in kubernetes-csi-migration-library.

Fixes: kubernetes-csi#99
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xing-yang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lpabon

If they are not already assigned, you can assign the PR to them by writing /assign @lpabon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 25, 2018
@xing-yang xing-yang mentioned this pull request Nov 25, 2018
Closed
@jsafrane
Copy link
Contributor

This is definitely step in the right direction, however, csi-api in kubernetes master requires client-go from 1.13.0-beta2, some fake client changed its API. And I can't update k8s.io/* to 1.13 in external attacher, dep fails with:

Solving failure: No versions of github.com/kubernetes-csi/kubernetes-csi-migration-library met constraints:
	master: Could not introduce github.com/kubernetes-csi/kubernetes-csi-migration-library@master, as it has a dependency on k8s.io/api with constraint kubernetes-1.12.1, which has no overlap with existing constraint kubernetes-1.13.0-beta.2 from (root)

kubernetes-csi-migration-library requires kubernetes-1.12.1.

@davidz627, any plans to update to newer kubernetes? Or is there a way how to force old kubernetes-csi-migration-library with newer k8s/*? The code works, just dep is not happy.

@jsafrane
Copy link
Contributor

I fixed the vendoring with some [[override]], see #101

@xing-yang
Copy link
Contributor Author

Close this one in favor of #101

@xing-yang xing-yang closed this Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@sbezverk sbezverk Awaiting requested review from sbezverk

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSINodeInfo should not be required
3 participants
@xing-yang @k8s-ci-robot @jsafrane