-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSI LIST_VOLUMES_PUBLISHED_NODES to the controller in mock #280
Conversation
Welcome @yuga711! |
Hi @yuga711. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @msau42 |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, yuga711 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds the LIST_VOLUMES_PUBLISHED_NODES capability to the mock. This will enable mock to be usable in cases such as CSI attacher reconciler. Ref: this logic in the external-attacher.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Used this modified csi-mock to verify this fix in external-attacher.
Does this PR introduce a user-facing change?: