Tests for raw block volumes are added #246

taaraora · 2020-02-04T21:19:45Z

**What type of PR is
/kind feature

What this PR does / why we need it:
It adds raw volumes tests.

Which issue(s) this PR fixes:

Fixes #174

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

csi-sanity --csi.testvolumeaccesstype=block now runs CSI tests with raw block volumes.

k8s-ci-robot · 2020-02-04T21:19:52Z

Welcome @taaraora!

It looks like this is your first PR to kubernetes-csi/csi-test 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-test has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-02-04T21:19:53Z

Hi @taaraora. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane · 2020-02-05T13:35:54Z

/ok-to-test

jsafrane

Code looks good, just I found only some nits. I'll test with a real CSI driver

jsafrane · 2020-02-12T09:47:38Z

pkg/sanity/controller.go

@@ -44,6 +45,22 @@ func TestVolumeSize(sc *TestContext) int64 {
 	return sc.Config.TestVolumeSize
 }

+func TestVolumeCapabilityWithAccessType(sc *TestContext, m csi.VolumeCapability_AccessMode_Mode) *csi.VolumeCapability {


nit: Test prefix implies that it actually tests something.

I was just following the way how getters are named in that file, e. g. TestVolumeSize, TestVolumeExpandSize

jsafrane · 2020-02-12T09:48:15Z

pkg/sanity/controller.go

-					VolumeId: vol.GetVolume().GetVolumeId(),
-					Secrets:  sc.Secrets.ControllerValidateVolumeCapabilitiesSecret,
+					VolumeId:           vol.GetVolume().GetVolumeId(),
+					VolumeCapabilities: nil,


Is this necessary?

No, it is not.
But the test case name is should fail when no volume capabilities are provided that is why I decided to emphasize that VolumeCapabilities is nil.

jsafrane · 2020-02-12T09:57:21Z

Also, please fix your commit messages, they're not really useful. Simple "block volume support" would be enough.

taaraora · 2020-02-12T10:47:36Z

Thank you, commit message is fixed now.

jsafrane · 2020-02-12T11:02:12Z

/assign

jsafrane · 2020-02-13T11:46:05Z

I tried with AWS EBS driver, it failed with various ListVolumes errors that look unrelated to block volumes [Edit: in other words, the block tests passed.]

@davidz627 @msau42, can you please test it with GCE PD?

saad-ali · 2020-02-13T17:54:39Z

CC @davidz627 please check this out

jsafrane · 2020-02-19T12:31:00Z

No one has reported any issues with the tests and it works for AWS and hostpath driver.
/lgtm
/approve

@taaraora, there seems to be something wrong with the release note in the first comment. Can you please check it has required format (without '\')? I would even rephrase it to:

```release-note
csi-sanity --csi.testvolumeaccesstype=block now runs CSI tests with raw block volumes.
\```

k8s-ci-robot · 2020-02-19T12:31:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, taaraora

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

taaraora · 2020-02-19T16:05:25Z

No one has reported any issues with the tests and it works for AWS and hostpath driver.
/lgtm
/approve

@taaraora, there seems to be something wrong with the release note in the first comment. Can you please check it has required format (without '\')? I would even rephrase it to:
```release-note
csi-sanity --csi.testvolumeaccesstype=block now runs CSI tests with raw block volumes.
\```

Thank you, I've fixed it.

Change go version to 1.21.5

227577e Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection e1ceee2 Always enable race detection while running tests 988496a Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c6 chore: bump to Go 1.22.5 69bd71e chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0cc Merge pull request kubernetes-csi#256 from solumath/master cfa9210 Instruction update 379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bb fix typo in sidecar release process 4967685 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160 Update skip list in codespell GitHub Action adb3af9 Merge pull request kubernetes-csi#252 from bells17/update-go-version f5aebfc Add GitHub Actions workflows b82ee38 Merge pull request kubernetes-csi#253 from bells17/fix-typo c317456 Fix typo 0a78505 Bump to Go 1.22.3 edd89ad Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck 043fd09 Add test-logcheck target d7535ae Merge pull request kubernetes-csi#250 from jsafrane/go-1.22 b52e7ad Update go to 1.22.2 14fdb6f Merge pull request kubernetes-csi#247 from msau42/prow dc4d0ae Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b17 Use .go-version to get Kubernetes go version 9b4352e Update release playbook c7bb972 Fix release notes script to use fixed tags 463a0e9 Add script to update specific go modules b54c1ba Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81 Change go version to 1.21.5 267b40e Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2 nominate self (carlory) as kubernetes-csi reviewer a17f536 Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033d Use set -x instead of die 5deaf66 Add wrapper script for sidecar release f8c8cc4 Merge pull request kubernetes-csi#237 from msau42/prow b36b5bf Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c465088 pull-test.sh: avoid "git subtree pull" error 7b175a1 Update csi-test version to v5.2.0 987c90c Update go version to 1.21 to match k/k 2c625d4 Add script to generate patch release notes f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd53 Bump csi-driver-host-path version up to v1.12.0 984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e605 fixed broken links of testgrid dashboard de2fba8 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1 cee895e remove windows 20H2 build since it's EOL long time ago 670bb0e Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors 35d5e78 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry 63473cc Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5 29a5c76 Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels 8dd2821 Update cloudbuild image with go 1.20.5 1df23db Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e Add ginkgo timeout to e2e tests to help catch any stuck tests 2b8b80e fixing some codespell errors c10b678 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions 72984ec chore: adopt kubernetes recommand label b055535 Header bd0a10b typo c39d73c Add comments f6491af Script to verify EOL sidecar version 4133d1d Merge pull request kubernetes-csi#226 from msau42/cloudbuild 8d519d2 Pin buildkit to v0.10.6 to workaround v0.11 bug with docker manifest 6e04a03 Merge pull request kubernetes-csi#224 from msau42/cloudbuild 26fdfff Update cloudbuild image 6613c39 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update 0e7ae99 Update k8s image repo url 77e47cc Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version 155854b Fix dep version mismatch 8f83905 Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update 1d3f94d Update go version to 1.20 to match k/k v1.27 e322ce5 Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error b74a512 test: fix golint error 901bcb5 Update registry k8s.gcr.io -> registry.k8s.io git-subtree-dir: release-tools git-subtree-split: 227577e

734c2b9 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch f95c855 Merge pull request kubernetes-csi#262 from huww98/golang-toolchain 3c8d966 Treat main branch as equivalent to master branch e31de52 Merge pull request kubernetes-csi#261 from huww98/golang fd153a9 Bump golang to 1.23.1 a8b3d05 pull-test.sh: fix "git subtree pull" errors 6b05f0f use new GOTOOLCHAIN env to manage go version 227577e Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection e1ceee2 Always enable race detection while running tests 988496a Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c6 chore: bump to Go 1.22.5 69bd71e chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0cc Merge pull request kubernetes-csi#256 from solumath/master cfa9210 Instruction update 379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bb fix typo in sidecar release process 4967685 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160 Update skip list in codespell GitHub Action adb3af9 Merge pull request kubernetes-csi#252 from bells17/update-go-version f5aebfc Add GitHub Actions workflows b82ee38 Merge pull request kubernetes-csi#253 from bells17/fix-typo c317456 Fix typo 0a78505 Bump to Go 1.22.3 edd89ad Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck 043fd09 Add test-logcheck target d7535ae Merge pull request kubernetes-csi#250 from jsafrane/go-1.22 b52e7ad Update go to 1.22.2 14fdb6f Merge pull request kubernetes-csi#247 from msau42/prow dc4d0ae Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b17 Use .go-version to get Kubernetes go version 9b4352e Update release playbook c7bb972 Fix release notes script to use fixed tags 463a0e9 Add script to update specific go modules b54c1ba Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81 Change go version to 1.21.5 267b40e Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2 nominate self (carlory) as kubernetes-csi reviewer a17f536 Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033d Use set -x instead of die 5deaf66 Add wrapper script for sidecar release f8c8cc4 Merge pull request kubernetes-csi#237 from msau42/prow b36b5bf Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c465088 pull-test.sh: avoid "git subtree pull" error 7b175a1 Update csi-test version to v5.2.0 987c90c Update go version to 1.21 to match k/k 2c625d4 Add script to generate patch release notes f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd53 Bump csi-driver-host-path version up to v1.12.0 984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e605 fixed broken links of testgrid dashboard de2fba8 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1 cee895e remove windows 20H2 build since it's EOL long time ago 670bb0e Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors 35d5e78 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry 63473cc Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5 29a5c76 Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels 8dd2821 Update cloudbuild image with go 1.20.5 1df23db Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e Add ginkgo timeout to e2e tests to help catch any stuck tests 2b8b80e fixing some codespell errors c10b678 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions 72984ec chore: adopt kubernetes recommand label b055535 Header bd0a10b typo c39d73c Add comments f6491af Script to verify EOL sidecar version 4133d1d Merge pull request kubernetes-csi#226 from msau42/cloudbuild 8d519d2 Pin buildkit to v0.10.6 to workaround v0.11 bug with docker manifest 6e04a03 Merge pull request kubernetes-csi#224 from msau42/cloudbuild 26fdfff Update cloudbuild image 6613c39 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update 0e7ae99 Update k8s image repo url 77e47cc Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version 155854b Fix dep version mismatch 8f83905 Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update 1d3f94d Update go version to 1.20 to match k/k v1.27 e322ce5 Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error b74a512 test: fix golint error 901bcb5 Update registry k8s.gcr.io -> registry.k8s.io git-subtree-dir: release-tools git-subtree-split: 734c2b950c4b31f64b63052c64ffa5929d1c9b97

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2020

k8s-ci-robot requested review from lpabon and saad-ali February 4, 2020 21:19

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 4, 2020

taaraora requested review from jsafrane and removed request for lpabon and saad-ali February 4, 2020 21:19

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 4, 2020

taaraora force-pushed the issue-174 branch from a0d10a5 to 5d7928b Compare February 5, 2020 12:06

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2020

jsafrane reviewed Feb 12, 2020

View reviewed changes

issue-174, block volume support

2cd2b9c

taaraora force-pushed the issue-174 branch from 5d7928b to 2cd2b9c Compare February 12, 2020 10:46

k8s-ci-robot assigned jsafrane Feb 12, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2020

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 19, 2020

k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 19, 2020

k8s-ci-robot merged commit 33de331 into kubernetes-csi:master Feb 19, 2020

stmcginnis pushed a commit to stmcginnis/csi-test that referenced this pull request Oct 9, 2024

Merge pull request kubernetes-csi#246 from xing-yang/go_1.21

b54c1ba

Change go version to 1.21.5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests for raw block volumes are added #246

Tests for raw block volumes are added #246

taaraora commented Feb 4, 2020 •

edited

Loading

k8s-ci-robot commented Feb 4, 2020

k8s-ci-robot commented Feb 4, 2020

jsafrane commented Feb 5, 2020

jsafrane left a comment

jsafrane Feb 12, 2020

taaraora Feb 12, 2020

jsafrane Feb 12, 2020

jsafrane Feb 12, 2020

taaraora Feb 12, 2020

jsafrane commented Feb 12, 2020

taaraora commented Feb 12, 2020

jsafrane commented Feb 12, 2020

jsafrane commented Feb 13, 2020 •

edited

Loading

saad-ali commented Feb 13, 2020

jsafrane commented Feb 19, 2020

k8s-ci-robot commented Feb 19, 2020

taaraora commented Feb 19, 2020

Tests for raw block volumes are added #246

Tests for raw block volumes are added #246

Conversation

taaraora commented Feb 4, 2020 • edited Loading

k8s-ci-robot commented Feb 4, 2020

k8s-ci-robot commented Feb 4, 2020

jsafrane commented Feb 5, 2020

jsafrane left a comment

Choose a reason for hiding this comment

jsafrane Feb 12, 2020

Choose a reason for hiding this comment

taaraora Feb 12, 2020

Choose a reason for hiding this comment

jsafrane Feb 12, 2020

Choose a reason for hiding this comment

jsafrane Feb 12, 2020

Choose a reason for hiding this comment

taaraora Feb 12, 2020

Choose a reason for hiding this comment

jsafrane commented Feb 12, 2020

taaraora commented Feb 12, 2020

jsafrane commented Feb 12, 2020

jsafrane commented Feb 13, 2020 • edited Loading

saad-ali commented Feb 13, 2020

jsafrane commented Feb 19, 2020

k8s-ci-robot commented Feb 19, 2020

taaraora commented Feb 19, 2020

taaraora commented Feb 4, 2020 •

edited

Loading

jsafrane commented Feb 13, 2020 •

edited

Loading