Update v0.3.0 branch to release 0.3.0-4 #140
Conversation
Create OWNERS file for https://github.com/kubernetes-csi/csi-test xref kubernetes/community#2467
The CSI spec doesn't require that NextToken is an integer, it should be treated as an opaque string, therefore remove an assertion that assumes it is an integer.
Connecting once per test made testing flaky. We could fix this with retries (kubernetes-csi#97) but that requires more discussion, so instead we just connect once per process instead of once per test case. This was also said to be faster (kubernetes-csi#98). Fixes: kubernetes-csi#101
Only the test suite itself may use those functions, but not the
tests. Should we ever accidentally add them back, then Ginkgo will
fail to run the embedded test case:
$ go test -v ./hack/_embedded/
panic: You may only call BeforeSuite once!
goroutine 1 [running]:
....
Create 2 new tests, one for a volume with a maximum-length name, and one for a snapshot with maximum-length name. These tests are intended to catch bugs where plugin authors use the value of the name field in a context where 128 characters exceeds a limit in some other system.
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lpabon, pohly, saad-ali If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
There seems to be a missing OWNERs file in the target branch? At least I get a 404 error when I clock on the OWNERS link from the robot: https://github.com/kubernetes-csi/csi-test/blob/v0.3.0/OWNERS @lpabon feel free to push directly to the new branch. |
…-libs go-get-kubernetes.sh: remove unused k8s libs
By mistake, I had released 0.3.0-3 from master which used the latest CSI spec instead of 0.3.0. This PR is created to cherry-pick all the changes from master to the v0.3.0 branch up to the version which changed the CSI spec in the vendor dir.