Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta APIs for FileSystem and SMB APIGroups #76

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Beta APIs for FileSystem and SMB APIGroups #76

merged 1 commit into from
Sep 14, 2020

Conversation

ddebroy
Copy link
Contributor

@ddebroy ddebroy commented Sep 14, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Introduces v1beta1 version of FileSystem and SMB API groups

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
The v1alpha1 APIs are copied over under the v1beta1 version. There is no difference in the APIs between alpha1 and beta1.

Does this PR introduce a user-facing change?:

Introduces v1beta1 version of FileSystem and SMB API groups

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 14, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 14, 2020
@ddebroy
Copy link
Contributor Author

ddebroy commented Sep 14, 2020

FS tests passing with v1beta1:

PS C:\Users\docker\go\github.com\kubernetes-csi\csi-proxy> go test -v .\integrationtests\filesystem_test.go
=== RUN   TestFilesystemAPIGroup
=== RUN   TestFilesystemAPIGroup/PathExists_positive
=== RUN   TestFilesystemAPIGroup/IsMount
--- PASS: TestFilesystemAPIGroup (0.04s)
    --- PASS: TestFilesystemAPIGroup/PathExists_positive (0.04s)
    --- PASS: TestFilesystemAPIGroup/IsMount (0.00s)
PASS
ok      command-line-arguments  0.462s

@jingxu97
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddebroy, jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c76bbd5 into kubernetes-csi:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants