-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add require-privacy option for New-SmbGlobalMapping (default: true) #315
Add require-privacy option for New-SmbGlobalMapping (default: true) #315
Conversation
Hi @vitaliy-leschenko. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, vitaliy-leschenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently New-SmbGlobalMapping is called always with option
-RequirePrivacy $true
. It might be a reason for the issue when SMB server doesn't support encryption. This PR allows to change this behavior by adding new flag (-require-privacy) to csi-proxy.exe. It is true by default for backward compatibility. If we want to allow call New-SmbGlobalMapping without -RequirePrivacy $true just add-require-privacy=false
to csi-proxy arguments.