Try to fix issue with 'Multiple connections to a server' #210

vitaliy-leschenko · 2022-06-28T19:21:57Z

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR allow to use pv/pvc for the same path more that once.
This PR allow to use many PVC based on storage class.

Which issue(s) this PR fixes:
Fixes kubernetes-csi/csi-driver-smb#385

Special notes for reviewer:
This PR has known issue: it still doesn't work for many PVC with the same smb-path but with different credentials.

Fix issue with impossible using a smb share more than once.

linux-foundation-easycla · 2022-06-28T19:22:02Z

The committers listed above are authorized under a signed CLA.

✅ login: vitaliy-leschenko / name: Vitaliy Leschenko (3aa0183)

k8s-ci-robot · 2022-06-28T19:22:06Z

Welcome @vitaliy-leschenko!

It looks like this is your first PR to kubernetes-csi/csi-proxy 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-proxy has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-06-28T19:22:07Z

Hi @vitaliy-leschenko. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andyzhangx · 2022-06-30T07:37:15Z

/ok-to-test

vitaliy-leschenko · 2022-06-30T11:17:07Z

/assign andyzhangx

vitaliy-leschenko · 2022-07-30T20:57:47Z

@ddebroy @andyzhangx I moved logic with reference counting to csi-driver-smb PR.
Now it compatible with old versions of csi-driver-smb and contains only API calls.

pkg/server/smb/server.go

andyzhangx · 2022-08-01T12:28:01Z

pkg/server/smb/server.go

@@ -25,6 +25,20 @@ func normalizeWindowsPath(path string) string {
 	return normalizedPath
 }

+func normalizeMappingPath(path string) string {


getRootMappingPath is better

pls also write a unit test for this func

andyzhangx · 2022-08-01T12:29:31Z

pkg/server/smb/server.go

+			}
+		}
+	}
+	return strings.ToLower("\\\\" + parts[0] + "\\" + parts[1])


if len(parts) < 2 it would panic

I will check it and cover in unit tests

pkg/server/smb/server.go

vitaliy-leschenko · 2022-08-03T12:59:51Z

@andyzhangx I've fixed tests. Please re-review.

andyzhangx

/lgtm
I will leave @mauriciopoppe to approve, thanks for the contribution.

k8s-ci-robot · 2022-08-04T10:35:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, vitaliy-leschenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mauriciopoppe · 2022-08-05T21:03:29Z

Interesting, someone approved it, it'd have been great to have this change as a single commit instead of 10 commits

shurick81 · 2023-09-04T13:56:36Z

Hi @mauriciopoppe @andyzhangx, do you by any chance know when to expect this release (1.1.2) in AKS? Is there a way to see in AKS which version of csi-proxy is deployed?

mauriciopoppe · 2023-09-05T16:30:42Z

Is there a way to see in AKS which version of csi-proxy is deployed?

I'm not familiar with AKS, however if you can SSH to a node you could find the version in the first lines of C:\etc\kubernetes\logs\csi-proxy.log, also, it might be possible that the path is different too. The kubernetes-csi community doesn't control the deployment of the binary, that's the task of the cluster administrator (in your case the devs that deploy Kubernetes in AKS).

227577e Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection e1ceee2 Always enable race detection while running tests 988496a Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c6 chore: bump to Go 1.22.5 69bd71e chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0cc Merge pull request kubernetes-csi#256 from solumath/master cfa9210 Instruction update 379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bb fix typo in sidecar release process 4967685 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160 Update skip list in codespell GitHub Action adb3af9 Merge pull request kubernetes-csi#252 from bells17/update-go-version f5aebfc Add GitHub Actions workflows b82ee38 Merge pull request kubernetes-csi#253 from bells17/fix-typo c317456 Fix typo 0a78505 Bump to Go 1.22.3 edd89ad Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck 043fd09 Add test-logcheck target d7535ae Merge pull request kubernetes-csi#250 from jsafrane/go-1.22 b52e7ad Update go to 1.22.2 14fdb6f Merge pull request kubernetes-csi#247 from msau42/prow dc4d0ae Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b17 Use .go-version to get Kubernetes go version 9b4352e Update release playbook c7bb972 Fix release notes script to use fixed tags 463a0e9 Add script to update specific go modules b54c1ba Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81 Change go version to 1.21.5 267b40e Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2 nominate self (carlory) as kubernetes-csi reviewer a17f536 Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033d Use set -x instead of die 5deaf66 Add wrapper script for sidecar release f8c8cc4 Merge pull request kubernetes-csi#237 from msau42/prow b36b5bf Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c465088 pull-test.sh: avoid "git subtree pull" error 7b175a1 Update csi-test version to v5.2.0 987c90c Update go version to 1.21 to match k/k 2c625d4 Add script to generate patch release notes f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd53 Bump csi-driver-host-path version up to v1.12.0 984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e605 fixed broken links of testgrid dashboard de2fba8 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1 cee895e remove windows 20H2 build since it's EOL long time ago 670bb0e Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors 35d5e78 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry 63473cc Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5 29a5c76 Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels 8dd2821 Update cloudbuild image with go 1.20.5 1df23db Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e Add ginkgo timeout to e2e tests to help catch any stuck tests 2b8b80e fixing some codespell errors c10b678 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions 72984ec chore: adopt kubernetes recommand label b055535 Header bd0a10b typo c39d73c Add comments f6491af Script to verify EOL sidecar version 901bcb5 Update registry k8s.gcr.io -> registry.k8s.io git-subtree-dir: release-tools git-subtree-split: 227577e00e93c3db4e732df1a71e37676fa33bfd

227577e Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection e1ceee2 Always enable race detection while running tests 988496a Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c6 chore: bump to Go 1.22.5 69bd71e chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0cc Merge pull request kubernetes-csi#256 from solumath/master cfa9210 Instruction update 379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bb fix typo in sidecar release process 4967685 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160 Update skip list in codespell GitHub Action adb3af9 Merge pull request kubernetes-csi#252 from bells17/update-go-version f5aebfc Add GitHub Actions workflows b82ee38 Merge pull request kubernetes-csi#253 from bells17/fix-typo c317456 Fix typo 0a78505 Bump to Go 1.22.3 edd89ad Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck 043fd09 Add test-logcheck target d7535ae Merge pull request kubernetes-csi#250 from jsafrane/go-1.22 b52e7ad Update go to 1.22.2 14fdb6f Merge pull request kubernetes-csi#247 from msau42/prow dc4d0ae Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b17 Use .go-version to get Kubernetes go version 9b4352e Update release playbook c7bb972 Fix release notes script to use fixed tags 463a0e9 Add script to update specific go modules b54c1ba Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81 Change go version to 1.21.5 267b40e Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2 nominate self (carlory) as kubernetes-csi reviewer a17f536 Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033d Use set -x instead of die 5deaf66 Add wrapper script for sidecar release f8c8cc4 Merge pull request kubernetes-csi#237 from msau42/prow b36b5bf Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c465088 pull-test.sh: avoid "git subtree pull" error 7b175a1 Update csi-test version to v5.2.0 987c90c Update go version to 1.21 to match k/k 2c625d4 Add script to generate patch release notes f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd53 Bump csi-driver-host-path version up to v1.12.0 984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e605 fixed broken links of testgrid dashboard de2fba8 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1 cee895e remove windows 20H2 build since it's EOL long time ago 670bb0e Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors 35d5e78 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry 63473cc Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5 29a5c76 Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels 8dd2821 Update cloudbuild image with go 1.20.5 1df23db Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e Add ginkgo timeout to e2e tests to help catch any stuck tests 2b8b80e fixing some codespell errors c10b678 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions 72984ec chore: adopt kubernetes recommand label b055535 Header bd0a10b typo c39d73c Add comments f6491af Script to verify EOL sidecar version 901bcb5 Update registry k8s.gcr.io -> registry.k8s.io git-subtree-dir: release-tools git-subtree-split: 227577e00e93c3db4e732df1a71e37676fa33bfd Signed-off-by: Terry Howe <[email protected]>

227577e Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection e1ceee2 Always enable race detection while running tests 988496a Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c6 chore: bump to Go 1.22.5 69bd71e chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0cc Merge pull request kubernetes-csi#256 from solumath/master cfa9210 Instruction update 379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bb fix typo in sidecar release process 4967685 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160 Update skip list in codespell GitHub Action adb3af9 Merge pull request kubernetes-csi#252 from bells17/update-go-version f5aebfc Add GitHub Actions workflows b82ee38 Merge pull request kubernetes-csi#253 from bells17/fix-typo c317456 Fix typo 0a78505 Bump to Go 1.22.3 edd89ad Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck 043fd09 Add test-logcheck target d7535ae Merge pull request kubernetes-csi#250 from jsafrane/go-1.22 b52e7ad Update go to 1.22.2 14fdb6f Merge pull request kubernetes-csi#247 from msau42/prow dc4d0ae Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b17 Use .go-version to get Kubernetes go version 9b4352e Update release playbook c7bb972 Fix release notes script to use fixed tags 463a0e9 Add script to update specific go modules b54c1ba Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81 Change go version to 1.21.5 267b40e Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2 nominate self (carlory) as kubernetes-csi reviewer a17f536 Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033d Use set -x instead of die 5deaf66 Add wrapper script for sidecar release f8c8cc4 Merge pull request kubernetes-csi#237 from msau42/prow b36b5bf Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c465088 pull-test.sh: avoid "git subtree pull" error 7b175a1 Update csi-test version to v5.2.0 987c90c Update go version to 1.21 to match k/k 2c625d4 Add script to generate patch release notes f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd53 Bump csi-driver-host-path version up to v1.12.0 984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e605 fixed broken links of testgrid dashboard de2fba8 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1 cee895e remove windows 20H2 build since it's EOL long time ago 670bb0e Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors 35d5e78 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry 63473cc Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5 29a5c76 Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels 8dd2821 Update cloudbuild image with go 1.20.5 1df23db Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e Add ginkgo timeout to e2e tests to help catch any stuck tests 2b8b80e fixing some codespell errors c10b678 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions 72984ec chore: adopt kubernetes recommand label b055535 Header bd0a10b typo c39d73c Add comments f6491af Script to verify EOL sidecar version 901bcb5 Update registry k8s.gcr.io -> registry.k8s.io git-subtree-dir: release-tools git-subtree-split: 227577e00e93c3db4e732df1a71e37676fa33bfd

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 28, 2022

k8s-ci-robot requested review from ddebroy and humblec June 28, 2022 19:22

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 28, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 28, 2022

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 28, 2022

vitaliy-leschenko force-pushed the fix_smb_mount branch 3 times, most recently from dd80e7d to 3aa0183 Compare June 28, 2022 19:46

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 28, 2022

vitaliy-leschenko changed the title ~~Try to fix issue with 'Multiple connections to a server'~~ [WIP] Try to fix issue with 'Multiple connections to a server' Jun 29, 2022

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 29, 2022

vitaliy-leschenko changed the title ~~[WIP] Try to fix issue with 'Multiple connections to a server'~~ Try to fix issue with 'Multiple connections to a server' Jun 29, 2022

vitaliy-leschenko mentioned this pull request Jun 29, 2022

feat: support RemoveSmbGlobalMapping during unmount on Windows node kubernetes-csi/csi-driver-smb#505

Merged

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 30, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2022

andyzhangx reviewed Jul 31, 2022

View reviewed changes

pkg/server/smb/server.go Show resolved Hide resolved

andyzhangx reviewed Aug 1, 2022

View reviewed changes

add unit tests

5c1def8

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2022

vitaliy-leschenko added 7 commits August 1, 2022 17:34

fix build

e20a78f

fix tests

82aaeb3

fix tests

db17460

fix build

c2b22a7

fix build

2476fe9

fix build

0cbab41

fix formatting

ce88358

mauriciopoppe reviewed Aug 1, 2022

View reviewed changes

pkg/server/smb/server.go Show resolved Hide resolved

fix tests+build

0b7cc3d

andyzhangx approved these changes Aug 4, 2022

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022

k8s-ci-robot merged commit fedd9da into kubernetes-csi:master Aug 4, 2022

vitaliy-leschenko deleted the fix_smb_mount branch August 4, 2022 11:10

andyzhangx mentioned this pull request Jan 20, 2023

The smb volume can't be mounted to the windows pod after reboot kubernetes-csi/csi-driver-smb#219

Closed

scottstout mentioned this pull request Aug 2, 2023

[BUG] Need Updated CSI-Proxy to Address Windows Volume Mount Issue rancher/rancher#42298

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try to fix issue with 'Multiple connections to a server' #210

Try to fix issue with 'Multiple connections to a server' #210

vitaliy-leschenko commented Jun 28, 2022 •

edited

Loading

linux-foundation-easycla bot commented Jun 28, 2022 •

edited

Loading

k8s-ci-robot commented Jun 28, 2022

k8s-ci-robot commented Jun 28, 2022

andyzhangx commented Jun 30, 2022

vitaliy-leschenko commented Jun 30, 2022

vitaliy-leschenko commented Jul 30, 2022

andyzhangx Aug 1, 2022

andyzhangx Aug 1, 2022

vitaliy-leschenko Aug 1, 2022

andyzhangx Aug 1, 2022

vitaliy-leschenko Aug 1, 2022

vitaliy-leschenko Aug 1, 2022

vitaliy-leschenko commented Aug 3, 2022

andyzhangx left a comment

k8s-ci-robot commented Aug 4, 2022

mauriciopoppe commented Aug 5, 2022

shurick81 commented Sep 4, 2023 •

edited

Loading

mauriciopoppe commented Sep 5, 2023

Try to fix issue with 'Multiple connections to a server' #210

Try to fix issue with 'Multiple connections to a server' #210

Conversation

vitaliy-leschenko commented Jun 28, 2022 • edited Loading

linux-foundation-easycla bot commented Jun 28, 2022 • edited Loading

k8s-ci-robot commented Jun 28, 2022

k8s-ci-robot commented Jun 28, 2022

andyzhangx commented Jun 30, 2022

vitaliy-leschenko commented Jun 30, 2022

vitaliy-leschenko commented Jul 30, 2022

andyzhangx Aug 1, 2022

Choose a reason for hiding this comment

andyzhangx Aug 1, 2022

Choose a reason for hiding this comment

vitaliy-leschenko Aug 1, 2022

Choose a reason for hiding this comment

andyzhangx Aug 1, 2022

Choose a reason for hiding this comment

vitaliy-leschenko Aug 1, 2022

Choose a reason for hiding this comment

vitaliy-leschenko Aug 1, 2022

Choose a reason for hiding this comment

vitaliy-leschenko commented Aug 3, 2022

andyzhangx left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 4, 2022

mauriciopoppe commented Aug 5, 2022

shurick81 commented Sep 4, 2023 • edited Loading

mauriciopoppe commented Sep 5, 2023

vitaliy-leschenko commented Jun 28, 2022 •

edited

Loading

linux-foundation-easycla bot commented Jun 28, 2022 •

edited

Loading

shurick81 commented Sep 4, 2023 •

edited

Loading