Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: use k8s-staging-test-infra/gcb-docker-gcloud #181

Merged
merged 1 commit into from
Dec 1, 2021
Merged

images: use k8s-staging-test-infra/gcb-docker-gcloud #181

merged 1 commit into from
Dec 1, 2021

Conversation

spiffxp
Copy link
Contributor

@spiffxp spiffxp commented Nov 30, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 30, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2021
@spiffxp spiffxp mentioned this pull request Nov 30, 2021
Open
77 tasks
@spiffxp
Copy link
Contributor Author

spiffxp commented Nov 30, 2021

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 30, 2021
@spiffxp
Copy link
Contributor Author

spiffxp commented Nov 30, 2021

I opened this because it appears #177 didn't update cloudbuild.yaml

Another option would be to update cloudbuild.yaml to be a symlink, as was done for e.g. kubernetes-csi/csi-driver-nfs#66

@spiffxp spiffxp force-pushed the use-k8s-infra-for-gcb-image branch from acb6cbe to cf5baae Compare November 30, 2021 21:02
andyzhangx
andyzhangx approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4c23ef2 into kubernetes-csi:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@gnufied gnufied Awaiting requested review from gnufied

@humblec humblec Awaiting requested review from humblec

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @andyzhangx